Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Requests Dependency Version to <= 2.25.99999 #218

Merged

Conversation

bartboy011
Copy link
Contributor

The Requests library has rolled out a few releases that are compatible with eventsourcing, so this PR simply brings the allowed versions of Requests up to date. One thing to note - version 2.25.x will be the last minor version to support Python 3.5, but this library requires 3.6 or greater anyway, so there's no issue there.

@bartboy011
Copy link
Contributor Author

Added context behind the "why" of this PR - I am working on integrating eventsourcing with FastAPI which currently have incompatible version requirements for Requests. This PR will reconcile those differences and allow eventsourcing and FastAPI to be used in tandem to create an async, event-sourced HTTP API microservice.

@coveralls
Copy link

coveralls commented Dec 21, 2020

Pull Request Test Coverage Report for Build 2922

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 96.884%

Files with Coverage Reduction New Missed Lines %
eventsourcing/system/runner.py 5 86.98%
Totals Coverage Status
Change from base Build 2920: -0.09%
Covered Lines: 5472
Relevant Lines: 5648

💛 - Coveralls

@johnbywater johnbywater changed the base branch from master to develop December 22, 2020 04:36
@johnbywater johnbywater merged commit d0cee5b into pyeventsourcing:develop Dec 22, 2020
@johnbywater
Copy link
Collaborator

Thanks a lot @bartboy011! I will release this change as v8.2.5 tomorrow.

@bartboy011
Copy link
Contributor Author

@johnbywater of course! Thank you for getting this out so quickly, much appreciated!

@johnbywater
Copy link
Collaborator

Just released to PyPI @bartboy011. I also updated the versions of the other dependencies.

https://eventsourcing.readthedocs.io/en/stable/topics/release_notes.html#version-8-2-5-released-22-dec-2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants