Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter with broken images can't be rendered #14

Open
troyeguo opened this issue Oct 29, 2023 · 1 comment · May be fixed by #18
Open

Chapter with broken images can't be rendered #14

troyeguo opened this issue Oct 29, 2023 · 1 comment · May be fixed by #18
Labels
bug Something isn't working

Comments

@troyeguo
Copy link

troyeguo commented Oct 29, 2023

When zip.js trys to uncompress these broken images, it will throw header error. But foliate.js doesn't properly catch these error which aborts the whole rendering process.

How to reproduce:

  1. Import this book in https://johnfactotum.github.io/foliate-js/reader.html
  2. Click Chapter 1 Probability

image

@johnfactotum
Copy link
Owner

Perhaps one should just catch this in the loadBlob function and return an empty Blob (or even a custom placeholder image, if you're feeling fancy)?

@ojaskavathe ojaskavathe linked a pull request Feb 18, 2024 that will close this issue
@johnfactotum johnfactotum added the bug Something isn't working label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants