INVALID feature/59-allow-uncentralized-barcode-and-qrcode

[SuddenGunter]

Description
allows uncentralized barcode/qrcode
main.go only for testing, will be remove when pr would be ready for review.
Result pdf for current main.go:

Same main.go on current dev:

I see 2 related issues:

• why qr code so blurry?
• why barcode ignores proportion (16x9 vs 4x3)?

Related Issue
resolve #59
resolve #60

Checklist

check with "x", if applied to your change

• All methods associated with structs has func (s *struct) method() {} name style.
• Wrote unit tests for new/changed features.
• Updated docs/doc.go
• Updated pkg/pdf/example_test.go
• Updated README.md
• New public methods has comments upside them explaining what it does
• Executed go fmt github.com/johnfercher/maroto/... to format all files

[codecov-io]

Codecov Report

Merging #94 into dev will increase coverage by 0.68%.
The diff coverage is 93.34%.

@@            Coverage Diff             @@
##              dev      #94      +/-   ##
==========================================
+ Coverage   95.69%   96.36%   +0.68%     
==========================================
  Files           8        8              
  Lines         463      466       +3     
==========================================
+ Hits          443      449       +6     
+ Misses         16       13       -3     
  Partials        4        4

Impacted Files	Coverage Δ
internal/code.go	100% <100%> (ø)	⬆️
pkg/pdf/pdf.go	91.5% <50%> (+1.21%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b630a80...4adad23. Read the comment docs.

[SuddenGunter]

codecov/patch — 93.34% of diff hit (target 95.67%)
codecov/project — 96.34% (+0.68%) compared to 87d45ab

@johnfercher do you have any idea what I've made wrong here?

[johnfercher]

• why qr code so blurry?
  Strange, I will check later.

• why barcode ignores proportion (16x9 vs 4x3)?
  In the master code it works, maybe your modification breaks the feature.

• do you have any idea what I've made wrong here?
  The code in the maroto.go Barcode doesn't have unit tests yet, we should add because your modification affect that code. You could follow de QrCode unit test example.

[SuddenGunter]

why barcode ignores proportion (16x9 vs 4x3)?
In the master code it works, maybe your modification breaks the feature.

I've tested code with dev without my changes - still wasn't working
UPD: will fix tests later tomorrow

[johnfercher]

Ouch, there is an inverted if lol, I'm so sorry.

maroto/pkg/props/prop.go

Lines 138 to 140 in 76210ee

	if r.Proportion.Height > r.Proportion.Width*0.33 {
	r.Proportion.Height = r.Proportion.Width * 0.33
	}

I will create another issue for that, thank you very much.

[SuddenGunter]

@johnfercher I guess I'd broke codecov when rebased branch and squashed some commits.
Can it happen, what do you think?
https://codecov.io/gh/johnfercher/maroto/compare/b630a80a0ee08a62b5a3047fc809a0e0a29744c3...00476f03195c85c336f7b9c3a86a7ebca6b61eb0

Missing base report. Unable to compare commits because the base of the compare did not upload a coverage report.
I'll delete this PR I guess and then recreate a new one. Sorry.

[SuddenGunter]

@johnfercher pls mark as INVALID