Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters? #48

Closed
Siyfion opened this issue Aug 29, 2014 · 6 comments
Closed

Filters? #48

Siyfion opened this issue Aug 29, 2014 · 6 comments

Comments

@Siyfion
Copy link
Contributor

Siyfion commented Aug 29, 2014

Should there be a section on filters?

@johnpapa
Copy link
Owner

I think there is something to say on filters. Next to directives, they may be the most abused feature in Angular, IMO. Filters can be a perf drain if not used wisely ... as when a filter hits a large and deep object graph. When used wisely, they are great. I'll consider adding some styles ... but mostly for filters, its about perf, which may not be appropriate in this doc.

@Siyfion
Copy link
Contributor Author

Siyfion commented Sep 1, 2014

While too much info on perf may not really belong in this document, I think it would still be worth mentioning that they are to be used with caution and add some basic style guidelines. 👍

@patrick-fls
Copy link

I think explaining briefly the performance issues coming with filters fit in this document, just like the use of IIFE is to avoid naming conflicts, for example.

@johnpapa
Copy link
Owner

johnpapa commented Sep 5, 2014

I'll keep this open and add something ... when I have some free time :)

@juristr
Copy link

juristr commented Sep 10, 2014

Maybe we should create a new document: "The opinionated AngularJS Performance Guide - by John Papa" 😏

@willmendesneto
Copy link

Based in this closed issue (angular/angular.js#10110) I guess that it's a good idea mention in the filter section that filters should not have periods or other special characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants