Adjust activity bar badge color based on background

[musicfuel]

The current colorization of the activity bar includes the background, foreground, and inactive background. The badge color that can appear over icons is still being maintained based on whatever the current theme is and is not reactive to the background color of the activity bar itself. This leads to potential usability/readability issues with the badge.

As an example, in my current Atom One Dark theme the badge color is a medium blue of #578afa. When using this in with the React Blue coloring the difference is subtle and difficult to see.

The problem gets even more noticeable if taking the extreme example where "Surprise Me" happened to land on the same color or even something close to it where the badge is effectively blended in.

Proposal

Leverage the tinycolor library to make intelligent color calculations to adjust the activity bar badge color to some form of a complementary color when the user has chosen to colorize the activity bar. The same images above with that type of logic might instead look like:

Version Information

macOS 10.14
VS Code 1.31 stable
Peacock 0.7.0

[johnpapa]

I agree 100%. I was experimenting with badge - but also don;t want to go too far into intruding on someone's theme. Therefore, I think 2 things may come of this:

1. Let's move forward with your proposed changes
2. Drafting guidelines for what Peacock should affect

[musicfuel]

Awesome. I have this partially in progress since I was just playing with it a bit. I will continue on that path and submit a PR.

I also agree with the guidelines.

[johnpapa]

perfect. it's all yours

[musicfuel]

The roadmap to 1.0 item for this in #56 can be marked done.