-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relocation moves classes to new package, but keeps old package in the JAR. #53
Comments
That shouldn't have any negative effect, it's just entry structure within the archive. I'm not sure I can do anything about it without having to do a second pass through the jar, which doesn't seem like a good practice. The reason is that the relocation is done on an entry by entry basis, but the parent directory structure needs to be created first and there is no way to know ahead of time if all the entries within the directory are going to be relocated. |
Hmm, yes it should not really matter. But actually I would prefer to have a clean JAR without unneeded entries so if you find a way to remove them maybe you can add an option for it because I don't mind waiting some seconds longer. |
I'm not going to add an option to do that. As I fix the relocation bug, I'll see if I can stop this (I think there is). |
Okay, thank you. :) |
So, after looking at this more, there is a part that I had to fix. Not only was it leaving the source directories around, I wasn't creating the directories for the target location. No big deal, unless you try to do some type of package scanning. So that should be fixed now. |
Just tested the new version 1.0.0 and it doesn't generate the old folders of the dependencies anymore. However, for some reason in the JAR file is an empty folder with the name of the file. (In my case |
When I relocate the guava package in my test project to another package, it moves the classes correctly but if I look into the JAR the folder of the original package still exists.
Guava has been moved to the correct package but there is still the
com
folder with all of the sub directories as well.The text was updated successfully, but these errors were encountered: