Resource files are no longer relocated

[pron]

Hi.
I've just upgraded from 0.8 to 1.1.1, and noticed that resource (non-class) files are no longer relocated. Is there a way to relocate them?

[pron]

Correction: it seems like the reference to the resource files (in the classes) are re-mapped to their supposed new location, it's just that the resource files themselves aren't moved.

[johnrengelman]

How are you doing the relocation? Relocation only applies to Java Class files because it has to do with changing package names and rewriting those in the corresponding .class files.

[pron]

relocate 'org.', 'mydom.org.'

• Relocation also has to do with changing files' paths.
• 0.8 relocated resource files as well as classes.
• The references to the resources are being transformed in the current version (e.g., ...getResourceAsStream("org/...") is (correctly) being turned into ...getResourceAsStream("mydom/org/..."))
• Resource files should be relocated because the shadow plugin is meant to prevent collisions (i.e. if some other transformation isn't applied).
• AFAIK (I may be wrong) the Maven Shade plugin also relocates resource files

[pron]

Hi.
Just tried 1.2.0 and unfortunately this doesn't seem to work (i.e. the problem persists exactly as reported before).

[pron]

OK, I think the problem is that you've applied the fix to visitFile but not to visitArchiveFile, so the relocation is not applied on dependencies.

[johnrengelman]

ah, my bad. I'll have a patch later today.

[pron]

Thanks!