Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take into account api scope on minimization #405

Merged
merged 11 commits into from
Oct 27, 2018
Merged

Take into account api scope on minimization #405

merged 11 commits into from
Oct 27, 2018

Conversation

osipxd
Copy link
Contributor

@osipxd osipxd commented Oct 1, 2018

This pull request fixes the case when we use minimize() in the project that have api scoped dependencies.

Dependencies scoped as api will be:

  • excluded from minimization
  • added to "project classes" (to avoid the case when dependencies used in API was removed on minimization)

@osipxd osipxd force-pushed the feature/api-scope-on-minimization branch from 2483b05 to e75852a Compare October 1, 2018 08:04
@osipxd osipxd force-pushed the feature/api-scope-on-minimization branch from e75852a to 9a286f2 Compare October 1, 2018 08:05
johnrengelman
johnrengelman reviewed Oct 6, 2018
View reviewed changes
Copy link
Collaborator

@johnrengelman johnrengelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! I should be able to get a new release out in the next couple of days.

@johnrengelman johnrengelman merged commit 7aa748e into GradleUp:master Oct 27, 2018
@johnrengelman johnrengelman added this to the 4.0.2 milestone Oct 27, 2018
@osipxd osipxd deleted the feature/api-scope-on-minimization branch October 28, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnrengelman johnrengelman johnrengelman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@osipxd @johnrengelman