Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The atomic add doesn't work on compute 6.1 #9

Closed
Ph0rk0z opened this issue Mar 22, 2023 · 5 comments
Closed

The atomic add doesn't work on compute 6.1 #9

Ph0rk0z opened this issue Mar 22, 2023 · 5 comments

Comments

@Ph0rk0z
Copy link
Contributor

Ph0rk0z commented Mar 22, 2023

I get error when I try to compile.

home/mint/text-generation-webui/repositories/GPTQ-for-LLaMa/quant_cuda_kernel.cu(548): error: no instance of overloaded function "atomicAdd" matches the argument list
            argument types are: (__half *, __half)

/home/mint/text-generation-webui/repositories/GPTQ-for-LLaMa/quant_cuda_kernel.cu(621): error: no instance of overloaded function "atomicAdd" matches the argument list
            argument types are: (__half *, __half)

Found the issue it came from but it seems like it's not using this function from where you defined it at the top.

@Ph0rk0z
Copy link
Contributor Author

Ph0rk0z commented Mar 22, 2023

If I rename the function I get:

error: argument of type "__half *" is incompatible with parameter of type "c10::Half *"

and now it built: https://pastebin.com/aykdsJJT

@Ph0rk0z
Copy link
Contributor Author

Ph0rk0z commented Mar 22, 2023

my dummy patch has worked.

Loading Model ...
Converted as Half.
Loaded the model in 4.71 seconds.
Fitting 4bit scales and zeros to half
 I think the meaning of life is to have a nice time, and that’s what we did on tour.
In your opinion
1.5773606300354004

@gururise
Copy link

my dummy patch has worked.

Loading Model ...
Converted as Half.
Loaded the model in 4.71 seconds.
Fitting 4bit scales and zeros to half
 I think the meaning of life is to have a nice time, and that’s what we did on tour.
In your opinion
1.5773606300354004

Nice! If it tests fine, are you planning on submitting a PR?

@nepeee nepeee mentioned this issue Mar 22, 2023
@Ph0rk0z
Copy link
Contributor Author

Ph0rk0z commented Mar 23, 2023

I could. Should it only be for cuda <7.0?

For <6.0 it needs the double one from here

I really want to make a fully merged GPTQ with this and GPT-J/GPT-X handling.

@Ph0rk0z
Copy link
Contributor Author

Ph0rk0z commented Mar 23, 2023

#14 so I made one for better or worse.

@Ph0rk0z Ph0rk0z closed this as completed Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants