Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design transformer does not update passthoughProps when its props are changed #17

Closed
e2thex opened this issue Jan 9, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@e2thex
Copy link
Collaborator

e2thex commented Jan 9, 2020

Description

Steps to reproduce

STR

open a product page
click bv placeholder
enter "BV Product External ID" (update product external id if it is already added)
click save

Expected result

bv placeholder content is updated

Actual result

bv placeholder content is not updated

Environment

Run gatsby info --clipboard in your project directory and paste the output here.

Affected Version

  • If the issue was encountered on a site, please attach your package.json
  • If the issue was encountered in the Bodiless-JS repo, please link to a
    commit or branch on which the issue occurs.
@e2thex
Copy link
Collaborator Author

e2thex commented Jan 14, 2020

fixed by pr #10

@e2thex e2thex closed this as completed Jan 14, 2020
hvanyo added a commit that referenced this issue Mar 29, 2022
* feature(bc-footer): Add Brand.com Footer

* feature(bc-footer): Final Styles Adjustments

* feature(bc-footer): Copyright as RTE, Add TODO On Social Links AND Removed Unnecessary FlowHoc

* feature(bc-footer): Move Sepator Styles To Its Own Token

* feature(bc-footer): Rename GlobalFooter To Footer

* feature(bc-footer): Address PR Feedback - Batch 1

* Reorganize menu. (#7)

* Reorganize menu.

* Remove redundant footer menu styling.

* Add submenu titles.

* Remove duplication in MenuTitleClean

* Fix lint

* Add canvasx token docs.

* feature(bc-footer): Fix doc typo

Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com>

* feature(bc-footer): Fix doc typo

Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com>

Co-authored-by: Guilherme Almeida Zeni <gzeni@ciandt.com>
Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com>

* feature(bc-footer): Update Footer Menu Data

* feature(bc-footer): Update Package.Lock

* feature(bc-footer): Remove Console Log From Menu Separator

* feature(bc-footer): Improve Footer Structure For Later Static Implementation

* feature(bc-footer): Add Todo Comments

* feature(bc-footer): Rename SiteHeader And SiteFooter To Header And Footer

* feature(bc-footer): Add Cx Navigation To TSConfig

* feature(bc-footer): Rename Remaining SiteHeader And SiteFooter To Header And Footer

* feature(bc-footer): Adjust Layout After Updates

* Token site constrains (#8)

* feature(bc-footer): Add Footer Slots Wrappers

* feature(bc-footer): Refactor Footer Copyright RichText

* feature(bc-footer): Update Footer And Copyright Keys

* feature(bc-footer): Add Footer Page Example

* feature(bc-footer): Feedback Fixes - Batch 2

* feature(bc-footer): Update Cx Navigation Package Version

* fix(bc-footer): Fix Footer Issues (#10)

* bugfix(bc-footer): Fix Footer Issues

* Remove top margin from in footnote

* Add uppercase to submenu items

* Removing unused imports

* bugfix(bc-footer): Fix comments on PR

* bugfix(bc-footer): Fix link issues

Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com>
Co-authored-by: guilhermegpessoa <guilherme.gpessoa@hotmail.com>

* feature(bc-footer): Fix issues after main branch update

* fix(bc-footer): Fix footer issues (#13)

* fix(bc-footer): Fix padding issues

* fix(bc-footer) Fix padding values

* fix(bc-footer): Fix padding issues

* feature(bc-footer): Update Footer Content

* bugfix(bc-footer): Fix Footer Menu Issues Issues (#16)

* bugfix(bc-footer): Fix Footer Menu Accessibility Issues

* bugfix(bc-footer): Add External And Download Icons To Menu Title Links

Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com>

* bugfix(bc-footer): Fix Mobile Margins Between Submenus (#17)

Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com>

Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com>
Co-authored-by: wodenx <wodenx@gmail.com>
Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com>
Co-authored-by: guilhermegpessoa <guilherme.gpessoa@hotmail.com>
Co-authored-by: guilhermegpessoa <48322825+guilhermegpessoa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant