Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fclasses) Design transformer does not update passthroughProps when its props are changed #10

Merged
merged 6 commits into from
Jan 14, 2020
Merged

fix(fclasses) Design transformer does not update passthroughProps when its props are changed #10

merged 6 commits into from
Jan 14, 2020

Conversation

beliayeu
Copy link
Collaborator

@beliayeu beliayeu commented Jan 9, 2020

Changes

  • fixed an issue with updating design transformer props

Test Instructions

  • open a product page on test site
  • click bv placeholder
  • enter "BV Product External ID" (update product external id if it is already added)
  • click save

actual: bv placeholder content is updated
expected: bv placeholder content is not updated

@beliayeu beliayeu requested review from e2thex and wodenx January 9, 2020 07:44
@beliayeu beliayeu changed the title fix(fclasses) Design transformer does not update passthoughProps when its props are changed fix(fclasses) Design transformer does not update passthroughProps when its props are changed Jan 9, 2020
@beliayeu beliayeu force-pushed the fix/design-transformer-props branch from 7796856 to fb63d1d Compare January 9, 2020 08:06
wodenx
wodenx suggested changes Jan 9, 2020
View reviewed changes
packages/fclasses/src/Design.tsx Outdated Show resolved Hide resolved
@e2thex e2thex mentioned this pull request Jan 9, 2020
Merged
e2thex
e2thex previously approved these changes Jan 10, 2020
View reviewed changes
@e2thex e2thex added the bug Something isn't working label Jan 10, 2020
wodenx
wodenx suggested changes Jan 10, 2020
View reviewed changes
packages/fclasses/src/Design.tsx Outdated Show resolved Hide resolved
@e2thex e2thex self-requested a review January 13, 2020 14:17
@e2thex e2thex requested a review from dewen January 13, 2020 14:18
dewen
dewen approved these changes Jan 14, 2020
View reviewed changes
Copy link
Collaborator

@dewen dewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on product page.

@e2thex e2thex merged commit 7395c41 into johnsonandjohnson:master Jan 14, 2020
@e2thex
Copy link
Collaborator

e2thex commented Jan 14, 2020

fix #17

@e2thex e2thex mentioned this pull request Jan 14, 2020
Closed
VancheeZze referenced this pull request in VancheeZze/Bodiless-JS Oct 22, 2020
@wodenx
Merge pull request #10 from VancheeZze/feat/mega-menu-qa-feedback-1
0035e41 
Address QA Feedback
misterjones pushed a commit to misterjones/Bodiless-JS that referenced this pull request Mar 3, 2022
@hvanyo
Merge pull request johnsonandjohnson#10 from misterjones/docs/typo
44e983c 
Update ToC structure
hvanyo added a commit that referenced this pull request Mar 29, 2022
@Guilherme-Almeida-Zeni @wodenx
@hvanyo @guilhermegpessoa
feat(bc-footer): Add Brand.com Footer (#1450)
9025ae5 
* feature(bc-footer): Add Brand.com Footer

* feature(bc-footer): Final Styles Adjustments

* feature(bc-footer): Copyright as RTE, Add TODO On Social Links AND Removed Unnecessary FlowHoc

* feature(bc-footer): Move Sepator Styles To Its Own Token

* feature(bc-footer): Rename GlobalFooter To Footer

* feature(bc-footer): Address PR Feedback - Batch 1

* Reorganize menu. (#7)

* Reorganize menu.

* Remove redundant footer menu styling.

* Add submenu titles.

* Remove duplication in MenuTitleClean

* Fix lint

* Add canvasx token docs.

* feature(bc-footer): Fix doc typo

Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com>

* feature(bc-footer): Fix doc typo

Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com>

Co-authored-by: Guilherme Almeida Zeni <gzeni@ciandt.com>
Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com>

* feature(bc-footer): Update Footer Menu Data

* feature(bc-footer): Update Package.Lock

* feature(bc-footer): Remove Console Log From Menu Separator

* feature(bc-footer): Improve Footer Structure For Later Static Implementation

* feature(bc-footer): Add Todo Comments

* feature(bc-footer): Rename SiteHeader And SiteFooter To Header And Footer

* feature(bc-footer): Add Cx Navigation To TSConfig

* feature(bc-footer): Rename Remaining SiteHeader And SiteFooter To Header And Footer

* feature(bc-footer): Adjust Layout After Updates

* Token site constrains (#8)

* feature(bc-footer): Add Footer Slots Wrappers

* feature(bc-footer): Refactor Footer Copyright RichText

* feature(bc-footer): Update Footer And Copyright Keys

* feature(bc-footer): Add Footer Page Example

* feature(bc-footer): Feedback Fixes - Batch 2

* feature(bc-footer): Update Cx Navigation Package Version

* fix(bc-footer): Fix Footer Issues (#10)

* bugfix(bc-footer): Fix Footer Issues

* Remove top margin from in footnote

* Add uppercase to submenu items

* Removing unused imports

* bugfix(bc-footer): Fix comments on PR

* bugfix(bc-footer): Fix link issues

Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com>
Co-authored-by: guilhermegpessoa <guilherme.gpessoa@hotmail.com>

* feature(bc-footer): Fix issues after main branch update

* fix(bc-footer): Fix footer issues (#13)

* fix(bc-footer): Fix padding issues

* fix(bc-footer) Fix padding values

* fix(bc-footer): Fix padding issues

* feature(bc-footer): Update Footer Content

* bugfix(bc-footer): Fix Footer Menu Issues Issues (#16)

* bugfix(bc-footer): Fix Footer Menu Accessibility Issues

* bugfix(bc-footer): Add External And Download Icons To Menu Title Links

Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com>

* bugfix(bc-footer): Fix Mobile Margins Between Submenus (#17)

Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com>

Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com>
Co-authored-by: wodenx <wodenx@gmail.com>
Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com>
Co-authored-by: guilhermegpessoa <guilherme.gpessoa@hotmail.com>
Co-authored-by: guilhermegpessoa <48322825+guilhermegpessoa@users.noreply.github.com>
misterjones pushed a commit to misterjones/Bodiless-JS that referenced this pull request Apr 7, 2022
@Guilherme-Almeida-Zeni @guilhermegpessoa
fix(bc-footer): Fix Footer Issues (johnsonandjohnson#10)
9ff0098 
* bugfix(bc-footer): Fix Footer Issues

* Remove top margin from in footnote

* Add uppercase to submenu items

* Removing unused imports

* bugfix(bc-footer): Fix comments on PR

* bugfix(bc-footer): Fix link issues

Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com>
Co-authored-by: guilhermegpessoa <guilherme.gpessoa@hotmail.com>
Guilherme-Almeida-Zeni added a commit that referenced this pull request Apr 12, 2022
@Guilherme-Almeida-Zeni @wodenx
@hvanyo @guilhermegpessoa
feat(cx-navigation): Add Cx Navigation #12 (#1495)
c191dac 
* feature(bc-footer): Add Brand.com Footer

* feature(bc-footer): Final Styles Adjustments

* feature(bc-footer): Copyright as RTE, Add TODO On Social Links AND Removed Unnecessary FlowHoc

* feature(bc-footer): Move Sepator Styles To Its Own Token

* feature(bc-footer): Rename GlobalFooter To Footer

* feature(bc-footer): Address PR Feedback - Batch 1

* Reorganize menu. (#7)

* Reorganize menu.

* Remove redundant footer menu styling.

* Add submenu titles.

* Remove duplication in MenuTitleClean

* Fix lint

* Add canvasx token docs.

* feature(bc-footer): Fix doc typo

Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com>

* feature(bc-footer): Fix doc typo

Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com>

Co-authored-by: Guilherme Almeida Zeni <gzeni@ciandt.com>
Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com>

* feature(bc-footer): Update Footer Menu Data

* feature(bc-footer): Update Package.Lock

* feature(bc-footer): Remove Console Log From Menu Separator

* feature(bc-footer): Improve Footer Structure For Later Static Implementation

* feature(bc-footer): Add Todo Comments

* feature(bc-footer): Rename SiteHeader And SiteFooter To Header And Footer

* feature(bc-footer): Add Cx Navigation To TSConfig

* feature(bc-footer): Rename Remaining SiteHeader And SiteFooter To Header And Footer

* feature(bc-footer): Adjust Layout After Updates

* Token site constrains (#8)

* feature(bc-footer): Add Footer Slots Wrappers

* feature(bc-footer): Refactor Footer Copyright RichText

* feature(bc-footer): Update Footer And Copyright Keys

* feature(bc-footer): Add Footer Page Example

* feature(bc-footer): Feedback Fixes - Batch 2

* feature(bc-footer): Update Cx Navigation Package Version

* fix(bc-footer): Fix Footer Issues (#10)

* bugfix(bc-footer): Fix Footer Issues

* Remove top margin from in footnote

* Add uppercase to submenu items

* Removing unused imports

* bugfix(bc-footer): Fix comments on PR

* bugfix(bc-footer): Fix link issues

Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com>
Co-authored-by: guilhermegpessoa <guilherme.gpessoa@hotmail.com>

* feature(bc-footer): Fix issues after main branch update

* feature(cx-navigation): Add CX Navigation

* feature(cx-navigation): Add WTB Button Placeholder

* feature(navigation): Update Content For Better Styling

* feature(bc-navigation): Style Burger Menu For Mobile And Tablet

* feature(bc-navigation): Fix Where To Buy Components Name

* feature(bc-navigation): Fix Issues Due To Conflict Resolution

* feature(bc-navigation): Reupdate Header After Conflicts Resolution

* feature(bc-navigation): Add Navigation Desktop Style

* fix(bc-footer): Fix footer issues (#13)

* fix(bc-footer): Fix padding issues

* fix(bc-footer) Fix padding values

* fix(bc-footer): Fix padding issues

* feature(navigation): Remove Unused Module Import

* feature(bc-navigation): Add NoWrap To Menus

* feature(bc-navigation): Address Feedback

* feature(bc-footer): Update Footer Content

* bugfix(bc-footer): Fix Footer Menu Issues Issues (#16)

* bugfix(bc-footer): Fix Footer Menu Accessibility Issues

* bugfix(bc-footer): Add External And Download Icons To Menu Title Links

Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com>

* Feature/bc navigation (#19)

* Replace WTB with styled link

* Fix lint

* Feature/cx navigation toggler (#20)

* Replace WTB with styled link

* Fix lint

* Remove burger menu toggler component.

Co-authored-by: Guilherme Almeida Zeni <gzeni@ciandt.com>

* feature(bc-navigation): Last Updates

* feature(bc-navigation): Remove Old Index File

* feature(bc-navigation): Update Header Constrains To Be In Container Component

* feature(bc-navigation): Fix Header BG After Main Updates

* docs(bc-navigation): BC Navigation Docs

* bugfix(bc-navigation): Fix Navigation Issues (#21)

Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com>

* feature(bc-navigation): Fix Submenu Paddings

* bugfix(bc-navigation): Fix Safari Burger Menu Issue And Add ID To Header (#22)

Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com>

* feature(bc-navigation): Fix Safari Issues (#24)

Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com>

* feature(cx-navigation): Update Tailwind Configs After Merge Conflicts Resolution

* feature(bc-navigation): Fix Top Nav Menu Style

Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com>
Co-authored-by: wodenx <wodenx@gmail.com>
Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com>
Co-authored-by: guilhermegpessoa <guilherme.gpessoa@hotmail.com>
Co-authored-by: guilhermegpessoa <48322825+guilhermegpessoa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e2thex e2thex e2thex approved these changes

@wodenx wodenx wodenx approved these changes

@dewen dewen dewen approved these changes

Assignees

@dewen dewen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@beliayeu @e2thex @wodenx @dewen