Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in Middleware support. #28

Closed
jcblw opened this issue Feb 13, 2021 · 3 comments
Closed

Add in Middleware support. #28

jcblw opened this issue Feb 13, 2021 · 3 comments

Comments

@jcblw
Copy link
Contributor

jcblw commented Feb 13, 2021

Right now we have a custom hook to add additional logging. I think this is fine but I think a more eloquent solution could be to use some sort of Middleware like outlined in this article.

https://link.medium.com/tq6FoquGQdb

@jcblw
Copy link
Contributor Author

jcblw commented Feb 13, 2021

We can use the package referenced since we are already using make executable schema.

https://github.com/maticzav/graphql-middleware

@jcblw
Copy link
Contributor Author

jcblw commented Feb 13, 2021

@arunsivasankaran I think this would allow us to have automatic light step tracing since there is some middleware for that.

@jcblw
Copy link
Contributor Author

jcblw commented Feb 20, 2021

added!

@jcblw jcblw closed this as completed Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant