Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR on disco import -z: no such column: m_match_method #16

Closed
JOJ0 opened this issue Jun 7, 2022 · 1 comment
Closed

ERROR on disco import -z: no such column: m_match_method #16

JOJ0 opened this issue Jun 7, 2022 · 1 comment

Comments

@JOJ0
Copy link
Owner

JOJ0 commented Jun 7, 2022

Thanks to @prcutler for reporting and finding the root cause for this bug. There definitely seems to be a wrong column name in the releases table named m_atch_method instead of m_match_method:

Adding Brainz info for track A3 on Please (24588)
Pet Shop Boys - Opportunities (Let's Make Lots Of Money)
Release MBID: 6045cfbd-ac4f-4736-b665-4f66faec4892
Recording MBID: fc8de196-f91d-401c-8ee6-5245e7aff815
Key: Cm  |  Chords Key: Cm  |  BPM: 120.202781677
ERROR DB: no such column: m_match_method
ERROR while updating release table. Continuing anyway.
1/9248```
@JOJ0 JOJ0 closed this as completed in 09d2d96 Jun 7, 2022
JOJ0 added a commit that referenced this issue Jun 7, 2022
JOJ0 added a commit that referenced this issue Jun 7, 2022
Removes wrongly named column m_atch_time in an existing db.
@JOJ0
Copy link
Owner Author

JOJ0 commented Jun 9, 2022

The issue has been fixed in the commit stated above (09d2d96). In case someone faces this error with an already existing database, these are the steps to fix in a install from git in a venv or the user's environment in a homedir:

  • Change into the DiscoDOS git repo: cd discodos
  • Update with git pull; python setup.py develop (or ..setup py install if you prefer that).
  • Run setup, schema upgrade needs to be forced: disco setup --force. Ignore the duplicate column name warnings.
  • An additional column m_match_time should have been created. To clear the wrong column, it can be deleted manually:
    • sqlite3 ~/.discodos/discobase.db < sql/db_repair_2022-06-07.sql (sqlite3 binary should be available in the discodos venv)

JOJ0 added a commit that referenced this issue Oct 29, 2024
- Fixes #16
- This corrects a typo in the schema version 2 upgrade dict in class
  config.Db_setup: m_atch_method -> m_match_method
JOJ0 added a commit that referenced this issue Oct 29, 2024
Removes wrongly named column m_atch_time in an existing db.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant