handle inline comments, and ignore spaces outside quotes

[lvanderree]

capable of handling inline comments (outside quotes).

So if you want "#" hashes in your values, place them inside quotes.

Also ignoring spaces outside quotes

[github-actions]

Your PR was set to target main, PRs should be target develop
The base branch of this PR has been automatically changed to develop, please check that there are no merge conflicts.

[lvanderree]

I noticed related issues that are addressed by this PR:

• Inline comments does not work #91
• handle inline comments, and ignore spaces outside quotes #475

[coveralls]

coverage: 92.255% (+0.04%) from 92.215% when pulling 09a965a on lvanderree:issue/91-inline-comments into 7f31fca on joke2k:develop.

[sergeyklay]

@lvanderree I've been looking through your pull request and in principle, everything looks great. I really like what you've done here. However, there seem to be a few builds that failed, notably the code style checks and linters.

Could you please have a look into why these didn't pass and make the necessary adjustments? It would greatly assist in maintaining our codebase's quality and readability.

Also, I would appreciate it if you could add an entry in the changelog about these changes. This would save me some time and ensure that we keep our documentation up to date.

[sergeyklay]

Great work on the PR! Noticed some linter warnings. Please, could you address them? After that, it'll be ready for merge. Thanks!

[sergeyklay]

Looks great. Thank you for contributing and patience

[jonnyhsu]

So if you want "#" hashes in your values, place them inside quotes.

Unfortunately the Django SECRET_KEY has "#" as a valid character, so this is actually a fairly serious breaking change.

[lvanderree]

Unfortunately the Django SECRET_KEY has "#" as a valid character, so this is actually a fairly serious breaking change.

what is the breaking change exactly? Have you got an example that isn't working anymore?
As far as a I see everything is still possible, but with the additional functionality to also be able to place comments

[sergeyklay]

.env file contents:

SECRET_KEY_499_1=abc#def
SECRET_KEY_499_2='abc#def'
SECRET_KEY_499_3='abc\#def'
SECRET_KEY_499_4="abc\#def"
SECRET_KEY_499_5=abc\#def

Test 2750dd5 (this PR)

SECRET_KEY_499_1=abc
SECRET_KEY_499_2=abc#def
SECRET_KEY_499_3=abc\#def
SECRET_KEY_499_4="abc\
SECRET_KEY_499_5=abc\

Test 8874288 (v0.10.0)

SECRET_KEY_499_1=abc#def
SECRET_KEY_499_2=abc#def
SECRET_KEY_499_3=abc\#def
SECRET_KEY_499_4=abc#def
SECRET_KEY_499_5=abc\#def

For more see: #499

[sergeyklay]

Hey @lvanderree,

I'm currently working on some modifications to the functionality you introduced in this PR. While the inline comments feature is useful, it has led to some unintended side effects that need addressing. I've opened a new pull request (see #500) to tackle these issues.

I'd appreciate your thoughts and any feedback you might have on this.

[jonnyhsu]

Unfortunately the Django SECRET_KEY has "#" as a valid character, so this is actually a fairly serious breaking change.

what is the breaking change exactly? Have you got an example that isn't working anymore? As far as a I see everything is still possible, but with the additional functionality to also be able to place comments

If the SECRET_KEY variable starts with a # then the site will not load, because a non-blank secret key is required. If the SECRET_KEY contains a #, then the key will be silently shortened which reduces security.

[painassasin]

String "ab#cd" does not work(

[sergeyklay]

See #500