Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make inline comments handling optional and disabled by default #500

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

sergeyklay
Copy link
Collaborator

@sergeyklay sergeyklay commented Sep 8, 2023

Disabled inline comments handling (that was introduced in #475) by default due to potential side effects. While the feature itself is useful, the project's philosophy dictates that it should not be enabled by default for all users.

Closes #499

@sergeyklay sergeyklay self-assigned this Sep 8, 2023
@sergeyklay sergeyklay added the bug Something isn't working label Sep 8, 2023
@coveralls
Copy link

coveralls commented Sep 8, 2023

Coverage Status

coverage: 92.268% (+0.05%) from 92.215% when pulling 35933b6 on fix/issue-499 into 7b5d7f9 on develop.

Disabled inline comments handling (that was introduced in #475)
by default due to potential side effects. While the feature itself is
useful, the project's philosophy dictates that it should not be enabled
by default for all users.

This also fix the issue described in the #499.
@lvanderree
Copy link
Contributor

👍 this is exactly what I had in mind after hearing about the issues: Add a feature flag to enable/disable it

@sergeyklay sergeyklay merged commit e3e7fc9 into develop Sep 22, 2023
51 checks passed
@sergeyklay sergeyklay deleted the fix/issue-499 branch September 22, 2023 15:47
@ognjenk
Copy link

ognjenk commented Oct 28, 2023

Do you maybe know when this fix might be pushed into release?

@sergeyklay
Copy link
Collaborator Author

Do you maybe know when this fix might be pushed into release?

We'll try to release next week.

@simonkern
Copy link

Sorry for bringing this issue up again, but any update on when this will be released? I've yet encountered another instance of corrupted session data because the SECRET_KEY was interpreted differently for uWSGI and gunicorn / uvicorn.

@jiayouzl
Copy link

Do you maybe know when this fix might be pushed into release?

We'll try to release next week.

Has the new version not been released yet? I have also encountered this problem.

I found that this issue only occurs in Ubuntu. The "#" symbol in the .env file is not affected on macOS system. What's going on?

@dklotz
Copy link

dklotz commented Mar 20, 2024

We'll try to release next week.

@sergeyklay Sorry to sound a bit pushy, but any updates on when this release will happen? This seems to affect a lot of people (cf #519), especially with SECRET_KEY and the related session data corruption.

@jiayouzl
Copy link

We'll try to release next week.

@sergeyklay Sorry to sound a bit pushy, but any updates on when this release will happen? This seems to affect a lot of people (cf #519), especially with SECRET_KEY and the related session data corruption.

I have been waiting for a long time too. In fact, they have already fixed it in the branch but just haven't released it. 😀

@dklotz
Copy link

dklotz commented Mar 21, 2024

I have been waiting for a long time too. In fact, they have already fixed it in the branch but just haven't released it. 😀

Yes, I also noticed that. For us the workaround for now is just using the version from the git develop branch in our pyproject.toml:

[tool.poetry.dependencies]
...
django-environ = { git = "https://github.com/joke2k/django-environ.git", rev = "a1113e41" } # TODO: switch to release once this bug is fixed: https://github.com/joke2k/django-environ/issues/519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants