Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically determine python and dot paths #44

Closed
wants to merge 3 commits into from
Closed

Automatically determine python and dot paths #44

wants to merge 3 commits into from

Conversation

tstenner
Copy link

This simple fix finds python and dot on the current system path, so dot in /usr/bin is found automatically.

@ss23
Copy link

ss23 commented Mar 28, 2013

There are configurations that will give the webserver an empty PATH environment variable, which would mean for those people, this patch is worse than before.

Rather than do this and break more configurations, I think a better fix would be to check whether dot / python can be find with the default path, and if not, try system, else give an error at that point.

@tstenner
Copy link
Author

Commit 787744f addresses this problem.
If the defaults aren't executable, they are being set with exec('which').

@alpha0010
Copy link
Collaborator

Too much auto-magic is not very portable. Webgrind currently displays a warning page if the executables are not available.

Closing.

@alpha0010 alpha0010 closed this Jul 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants