Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Context] nullable properties (like timeout) no longer resetable #326

Closed
pyrech opened this issue Mar 14, 2024 · 0 comments · Fixed by #327
Closed

[Context] nullable properties (like timeout) no longer resetable #326

pyrech opened this issue Mar 14, 2024 · 0 comments · Fixed by #327

Comments

@pyrech
Copy link
Member

pyrech commented Mar 14, 2024

Passing a null value to the $c->withTimeout() no longer works since 41f0756#diff-3cce1ea0450771adbc3cae800dc672c1edde9f76fc377da115e1ca05c8da926cR153

null ?? $defaultValue will always return the default value, thus it's now impossible to reset the timeout if it has been set before.

For example, this is an issue when using the watch() function when the default context configures a timeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert simplification of context jolicode/castor
1 participant
@pyrech