Internal services #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 2, 2015 11:35
…loading embedded services
| } | ||
| else if (this.internalServiceProgram != null) { | ||
| program = this.internalServiceProgram; | ||
| OLParseTreeOptimizer optimizer = new OLParseTreeOptimizer( program ); |
There was a problem hiding this comment.
Looks like this code is duplicated with the one in the next branch.
|
Great patch, thanks. :-) Indentation looks weird sometimes. Please follow the style of the rest of the code (spaces in parentheses) and use tabs instead of spaces. @jolie/developers More eyeballs on the patch are welcome. |
|
The formatting rules I used (updated to last year I think, but netbeans should not have changed so much hopefully?..) |
|
Again, thank you for the comments and recommendations! The latest commits should fix the concerns that you had. Let me know if further changes are needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for internal services