Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upInternal services #45
Conversation
added some commits
May 2, 2015
fmontesi
reviewed
May 18, 2015
| } | ||
| else if (this.internalServiceProgram != null) { | ||
| program = this.internalServiceProgram; | ||
| OLParseTreeOptimizer optimizer = new OLParseTreeOptimizer( program ); |
This comment has been minimized.
This comment has been minimized.
fmontesi
reviewed
May 18, 2015
| this.type = type; | ||
| } | ||
|
|
||
| public Constants.EmbeddedServiceType getType() |
This comment has been minimized.
This comment has been minimized.
fmontesi
reviewed
May 18, 2015
| null, | ||
| protocolConfiguration, | ||
| new InputPortInfo.AggregationItemInfo[] {}, | ||
| new HashMap<String, String>() ); |
This comment has been minimized.
This comment has been minimized.
fmontesi
reviewed
May 18, 2015
| //initialize internal interface and interface list | ||
| List< InterfaceDefinition > interfaceList = new ArrayList< InterfaceDefinition >(); | ||
|
|
||
| OLSyntaxNode internal_main = null; |
This comment has been minimized.
This comment has been minimized.
fmontesi
reviewed
May 18, 2015
| List< InterfaceDefinition > interfaceList = new ArrayList< InterfaceDefinition >(); | ||
|
|
||
| OLSyntaxNode internal_main = null; | ||
| SequenceStatement internal_init = null; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fmontesi
May 18, 2015
Member
internal_init could probably just be OLSyntaxNode, SequenceStatement seems redundant.
fmontesi
reviewed
May 18, 2015
| @@ -30,6 +32,8 @@ | |||
| private final String servicePath; | |||
| private final String portId; | |||
| private final Constants.EmbeddedServiceType type; | |||
|
|
|||
| private final List< OLSyntaxNode > children = new ArrayList< OLSyntaxNode > (); | |||
This comment has been minimized.
This comment has been minimized.
fmontesi
reviewed
May 18, 2015
| @@ -0,0 +1,458 @@ | |||
| /*************************************************************************** | |||
This comment has been minimized.
This comment has been minimized.
fmontesi
May 18, 2015
Member
Where is this class used? Please remove it if unused (we could move it to an external library though maybe... but let's leave it for another patch).
fmontesi
reviewed
May 18, 2015
| if ( child instanceof TypeInlineDefinition || | ||
| child instanceof InterfaceDefinition || | ||
| child instanceof OutputPortInfo || | ||
| child instanceof EmbeddedServiceNode ) |
This comment has been minimized.
This comment has been minimized.
fmontesi
May 18, 2015
Member
This does not look like the right way of implementing the first requirement in Semantics of #27 .
It's going to duplicate embedded services, which could be a problem in case of sub-services written in Jolie (and even Java, although many are harmless, like Console).
What we should do is implement some mechanism for the internal service to wait for the bindings for the output ports at runtime. This doesn't look too easy, we need to think of the lifecycle defined in:
https://github.com/jolie/jolie/blob/master/jolie/src/jolie/process/InitDefinitionProcess.java
Embedded services are loaded before the init procedure starts, so the internal service can't wait for the parent's init to end before "copying over" the bindings for the output ports or we'll create a deadlock.
This comment has been minimized.
This comment has been minimized.
|
Great patch, thanks. :-) Indentation looks weird sometimes. Please follow the style of the rest of the code (spaces in parentheses) and use tabs instead of spaces. @jolie/developers More eyeballs on the patch are welcome. |
fmontesi
self-assigned this
May 18, 2015
fmontesi
added this to the v1.4 milestone
May 18, 2015
fmontesi
added
the
enhancement
label
May 18, 2015
This comment has been minimized.
This comment has been minimized.
|
The formatting rules I used (updated to last year I think, but netbeans should not have changed so much hopefully?..) |
fmontesi
and others
added some commits
May 19, 2015
This comment has been minimized.
This comment has been minimized.
mawolf
commented
May 19, 2015
|
Again, thank you for the comments and recommendations! The latest commits should fix the concerns that you had. Let me know if further changes are needed! |
mawolf commentedMay 18, 2015
Adding support for internal services