Automated builds through Fastlane #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chunningham
commented
Jan 23, 2020
chunningham
commented
…ned build lane for android
…o staging for ios
…se staging build for local
…martwallet-app into feat/1509/fastlane_integration
use ios-deploy from brew instead fastlane load_json plugin is not needed
iOS devices access the dev server over the network, and the device needs to be on the same network for this to work. And the network needs to allow it of course, so this was non-functional in Betahaus. This is probably the only reference to Betahaus in our git logs; this is their legacy. Anyway, there's an xcode build phase script (node_modules/react-native/scripts/react-native-xcode.sh) which "guesses" the build machine's IP and writes it to a text file inside the .ipa, which is then loaded by the react bridge. Closes #1396
mnzaki
force-pushed
the
feat/1509/fastlane_integration
branch
from
da7fb93
to
2fd8f0f
Compare
This was referenced Feb 19, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.