Compatibility pass on flutter/widgets tests for JavaScript compilatio…

…n. (8) (flutter#33377)

dev/bots/test.dart

@@ -348,6 +348,7 @@ Future<void> _runWebTests() async {
     'test/services/',
     'test/painting/',
     'test/scheduler/',
+    'test/widgets/',
     'test/semantics/',
   ]);
 }

packages/flutter/lib/src/services/text_input.dart

@@ -15,6 +15,9 @@ import 'text_editing.dart';
 
 export 'dart:ui' show TextAffinity;
 
+// Whether we're compiled to JavaScript in a web browser.
+const bool _kIsBrowser = identical(0, 0.0);
+
 /// The type of information for which to optimize the text input control.
 ///
 /// On Android, behavior may vary across device and keyboard provider.
@@ -825,6 +828,10 @@ class TextInput {
 
   static bool _debugEnsureInputActionWorksOnPlatform(TextInputAction inputAction) {
     assert(() {
+      if (_kIsBrowser) {
+        // TODO(flutterweb): what makes sense here?
+        return true;
+      }
       if (Platform.isIOS) {
         assert(
           _iOSSupportedInputActions.contains(inputAction),

packages/flutter/test/widgets/actions_test.dart

@@ -286,6 +286,6 @@ void main() {
 
       expect(description[0], equalsIgnoringHashCodes('dispatcher: ActionDispatcher#00000'));
       expect(description[1], equals('actions: {[<\'bar\'>]: Closure: () => TestAction}'));
-    });
+    }, skip: isBrowser);
   });
 }

packages/flutter/test/widgets/app_title_test.dart

@@ -55,6 +55,6 @@ void main() {
     await tester.pump();
     expect(tester.widget<Title>(find.byType(Title)).title, 'en_US');
     expect(tester.widget<Title>(find.byType(Title)).color, kTitleColor);
-  });
+  }, skip: isBrowser);
 
 }

packages/flutter/test/widgets/backdrop_filter_test.dart

@@ -46,5 +46,5 @@ void main() {
       matchesGoldenFile('backdrop_filter_test.cull_rect.1.png'),
       skip: !isLinux,
     );
-  });
+  }, skip: isBrowser);
 }

packages/flutter/test/widgets/baseline_test.dart

@@ -19,7 +19,7 @@ void main() {
       ),
     );
     expect(tester.renderObject<RenderBox>(find.text('X')).size, const Size(100.0, 100.0));
-  });
+  }, skip: isBrowser);
 
   testWidgets('Baseline - position test', (WidgetTester tester) async {
     await tester.pumpWidget(
@@ -40,7 +40,7 @@ void main() {
     expect(tester.renderObject<RenderBox>(find.text('X')).size, const Size(100.0, 100.0));
     expect(tester.renderObject<RenderBox>(find.byType(Baseline)).size,
            within<Size>(from: const Size(100.0, 200.0), distance: 0.001));
-  });
+  }, skip: isBrowser);
 
   testWidgets('Chip caches baseline', (WidgetTester tester) async {
     int calls = 0;
@@ -65,7 +65,7 @@ void main() {
     tester.renderObject<RenderBaselineDetector>(find.byType(BaselineDetector)).dirty();
     await tester.pump();
     expect(calls, 2);
-  });
+  }, skip: isBrowser);
 
   testWidgets('ListTile caches baseline', (WidgetTester tester) async {
     int calls = 0;

packages/flutter/test/widgets/basic_test.dart

@@ -51,7 +51,7 @@ void main() {
       expect(tester.hitTestOnBinding(const Offset(100.0, 300.0)), hits(renderPhysicalShape));
       expect(tester.hitTestOnBinding(const Offset(100.0, 299.0)), doesNotHit(renderPhysicalShape));
       expect(tester.hitTestOnBinding(const Offset(100.0, 301.0)), doesNotHit(renderPhysicalShape));
-    });
+    }, skip: isBrowser);
 
   });
 
@@ -202,7 +202,7 @@ void main() {
         tester.getTopLeft(find.byKey(key2)).dy,
         closeTo(aboveBaseline1 - aboveBaseline2, .001),
       );
-    });
+    }, skip: isBrowser);
   });
 
   test('UnconstrainedBox toString', () {

packages/flutter/test/widgets/clip_test.dart

@@ -358,7 +358,7 @@ void main() {
       find.byType(RepaintBoundary).first,
       matchesGoldenFile('clip.ClipRect.1.png'),
     );
-  });
+  }, skip: isBrowser);
 
   testWidgets('ClipRect save, overlay, and antialiasing', (WidgetTester tester) async {
     await tester.pumpWidget(
@@ -398,7 +398,7 @@ void main() {
       find.byType(RepaintBoundary).first,
       matchesGoldenFile('clip.ClipRectOverlay.1.png'),
     );
-  });
+  }, skip: isBrowser);
 
   testWidgets('ClipRRect painting', (WidgetTester tester) async {
     await tester.pumpWidget(
@@ -447,7 +447,7 @@ void main() {
       find.byType(RepaintBoundary).first,
       matchesGoldenFile('clip.ClipRRect.1.png'),
     );
-  });
+  }, skip: isBrowser);
 
   testWidgets('ClipOval painting', (WidgetTester tester) async {
     await tester.pumpWidget(
@@ -490,7 +490,7 @@ void main() {
       find.byType(RepaintBoundary).first,
       matchesGoldenFile('clip.ClipOval.1.png'),
     );
-  });
+  }, skip: isBrowser);
 
   testWidgets('ClipPath painting', (WidgetTester tester) async {
     await tester.pumpWidget(
@@ -538,7 +538,7 @@ void main() {
       find.byType(RepaintBoundary).first,
       matchesGoldenFile('clip.ClipPath.1.png'),
     );
-  });
+  }, skip: isBrowser);
 
   Center genPhysicalModel(Clip clipBehavior) {
     return Center(
@@ -583,15 +583,15 @@ void main() {
       find.byType(RepaintBoundary).first,
       matchesGoldenFile('clip.PhysicalModel.antiAlias.1.png'),
     );
-  });
+  }, skip: isBrowser);
 
   testWidgets('PhysicalModel painting with Clip.hardEdge', (WidgetTester tester) async {
     await tester.pumpWidget(genPhysicalModel(Clip.hardEdge));
     await expectLater(
       find.byType(RepaintBoundary).first,
       matchesGoldenFile('clip.PhysicalModel.hardEdge.1.png'),
     );
-  });
+  }, skip: isBrowser);
 
   // There will be bleeding edges on the rect edges, but there shouldn't be any bleeding edges on the
   // round corners.
@@ -601,7 +601,7 @@ void main() {
       find.byType(RepaintBoundary).first,
       matchesGoldenFile('clip.PhysicalModel.antiAliasWithSaveLayer.png'),
     );
-  });
+  }, skip: isBrowser);
 
   testWidgets('Default PhysicalModel painting', (WidgetTester tester) async {
     await tester.pumpWidget(
@@ -643,7 +643,7 @@ void main() {
       find.byType(RepaintBoundary).first,
       matchesGoldenFile('clip.PhysicalModel.default.1.png'),
     );
-  });
+  }, skip: isBrowser);
 
   Center genPhysicalShape(Clip clipBehavior) {
     return Center(
@@ -692,23 +692,23 @@ void main() {
       find.byType(RepaintBoundary).first,
       matchesGoldenFile('clip.PhysicalShape.antiAlias.1.png'),
     );
-  });
+  }, skip: isBrowser);
 
   testWidgets('PhysicalShape painting with Clip.hardEdge', (WidgetTester tester) async {
     await tester.pumpWidget(genPhysicalShape(Clip.hardEdge));
     await expectLater(
       find.byType(RepaintBoundary).first,
       matchesGoldenFile('clip.PhysicalShape.hardEdge.1.png'),
     );
-  });
+  }, skip: isBrowser);
 
   testWidgets('PhysicalShape painting with Clip.antiAliasWithSaveLayer', (WidgetTester tester) async {
     await tester.pumpWidget(genPhysicalShape(Clip.antiAliasWithSaveLayer));
     await expectLater(
       find.byType(RepaintBoundary).first,
       matchesGoldenFile('clip.PhysicalShape.antiAliasWithSaveLayer.png'),
     );
-  });
+  }, skip: isBrowser);
 
   testWidgets('PhysicalShape painting', (WidgetTester tester) async {
     await tester.pumpWidget(
@@ -754,7 +754,7 @@ void main() {
       find.byType(RepaintBoundary).first,
       matchesGoldenFile('clip.PhysicalShape.default.1.png'),
     );
-  });
+  }, skip: isBrowser);
 
   testWidgets('ClipPath.shape', (WidgetTester tester) async {
     final List<String> logs = <String>[];

packages/flutter/test/widgets/custom_painter_test.dart

@@ -493,7 +493,7 @@ void _defineTests() {
     );
     expect(semantics, hasSemantics(expectedSemantics, ignoreRect: true, ignoreTransform: true));
     semantics.dispose();
-  });
+  }, skip: isBrowser);
 
   group('diffing', () {
     testWidgets('complains about duplicate keys', (WidgetTester tester) async {

packages/flutter/test/widgets/draggable_scrollable_sheet_test.dart

@@ -101,7 +101,7 @@ void main() {
         expect(find.text('Item 1'), findsOneWidget);
         expect(find.text('Item 21'), findsOneWidget);
         expect(find.text('Item 31'), findsOneWidget);
-      });
+      }, skip: isBrowser);
 
       testWidgets('Can be dragged down when not full height', (WidgetTester tester) async {
         await tester.pumpWidget(_boilerplate(null));
@@ -114,7 +114,7 @@ void main() {
         expect(find.text('Item 1'), findsOneWidget);
         expect(find.text('Item 21'), findsNothing);
         expect(find.text('Item 36'), findsNothing);
-      });
+      }, skip: isBrowser);
 
       testWidgets('Can be dragged down when list is shorter than full height', (WidgetTester tester) async {
         await tester.pumpWidget(_boilerplate(null, itemCount: 30, initialChildSize: .25));
@@ -131,7 +131,7 @@ void main() {
         await tester.pumpAndSettle();
         expect(find.text('Item 1').hitTestable(), findsOneWidget);
         expect(find.text('Item 29').hitTestable(), findsNothing);
-      });
+      }, skip: isBrowser);
 
       testWidgets('Can be dragged up and cover its container and scroll in single motion, and then dragged back down', (WidgetTester tester) async {
         int taps = 0;
@@ -160,7 +160,7 @@ void main() {
         expect(find.text('Item 1'), findsOneWidget);
         expect(find.text('Item 18'), findsOneWidget);
         expect(find.text('Item 36'), findsNothing);
-      });
+      }, skip: isBrowser);
 
       testWidgets('Can be flung up gently', (WidgetTester tester) async {
         int taps = 0;
@@ -183,7 +183,7 @@ void main() {
         expect(find.text('Item 21'), findsOneWidget);
         expect(find.text('Item 36'), findsOneWidget);
         expect(find.text('Item 70'), findsNothing);
-      });
+      }, skip: isBrowser);
 
       testWidgets('Can be flung up', (WidgetTester tester) async {
         int taps = 0;
@@ -204,7 +204,7 @@ void main() {
         expect(find.text('Item 1'), findsNothing);
         expect(find.text('Item 21'), findsNothing);
         expect(find.text('Item 70'), findsOneWidget);
-      });
+      }, skip: isBrowser);
 
       testWidgets('Can be flung down when not full height', (WidgetTester tester) async {
         await tester.pumpWidget(_boilerplate(null));
@@ -217,7 +217,7 @@ void main() {
         expect(find.text('Item 1'), findsOneWidget);
         expect(find.text('Item 21'), findsNothing);
         expect(find.text('Item 36'), findsNothing);
-      });
+      }, skip: isBrowser);
 
       testWidgets('Can be flung up and then back down', (WidgetTester tester) async {
         int taps = 0;
@@ -256,7 +256,7 @@ void main() {
         expect(find.text('Item 1'), findsOneWidget);
         expect(find.text('Item 21'), findsNothing);
         expect(find.text('Item 70'), findsNothing);
-      });
+      }, skip: isBrowser);
 
       debugDefaultTargetPlatformOverride = null;
     });

packages/flutter/test/widgets/draggable_test.dart

@@ -2085,8 +2085,7 @@ void main() {
         ],
     ), ignoreTransform: true, ignoreRect: true));
     semantics.dispose();
-  });
-
+  }, skip: isBrowser);
 }
 
 Future<void> _testLongPressDraggableHapticFeedback({ WidgetTester tester, bool hapticFeedbackOnStart, int expectedHapticFeedbackCount }) async {

packages/flutter/test/widgets/editable_text_cursor_test.dart

@@ -445,7 +445,7 @@ void main() {
     await tester.pumpAndSettle();
 
     expect(controller.selection.baseOffset, 10);
-  });
+  }, skip: isBrowser);
 
   testWidgets('Updating the floating cursor correctly moves the cursor', (WidgetTester tester) async {
     const String text = 'hello world this is fun and cool and awesome!';
@@ -501,7 +501,7 @@ void main() {
     await tester.pumpAndSettle();
     // The cursor has been set.
     expect(controller.selection.baseOffset, 10);
-  });
+  }, skip: isBrowser);
 
   // Regression test for https://github.com/flutter/flutter/pull/30475.
   testWidgets('Trying to select with the floating cursor does not crash', (WidgetTester tester) async {
@@ -567,7 +567,7 @@ void main() {
       offset: const Offset(-250, 20)));
     editableTextState.updateFloatingCursor(RawFloatingCursorPoint(state: FloatingCursorDragState.End));
     await tester.pumpAndSettle();
-  });
+  }, skip: isBrowser);
 
   testWidgets('autofocus sets cursor to the end of text', (WidgetTester tester) async {
     const String text = 'hello world';
@@ -599,7 +599,7 @@ void main() {
     expect(focusNode.hasFocus, true);
     expect(controller.selection.isCollapsed, true);
     expect(controller.selection.baseOffset, text.length);
-  });
+  }, skip: isBrowser);
 
   testWidgets('Floating cursor is painted on iOS', (WidgetTester tester) async {
     debugDefaultTargetPlatformOverride = TargetPlatform.iOS;
@@ -687,7 +687,7 @@ void main() {
     editableTextState.updateFloatingCursor(RawFloatingCursorPoint(state: FloatingCursorDragState.End));
     await tester.pumpAndSettle();
     debugDefaultTargetPlatformOverride = null;
-  });
+  }, skip: isBrowser);
 
   testWidgets('cursor layout iOS', (WidgetTester tester) async {
     final GlobalKey<EditableTextState> editableTextKey = GlobalKey<EditableTextState>();