Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results are duplicated #12

Closed
Djfe opened this issue Dec 4, 2014 · 6 comments
Closed

Search results are duplicated #12

Djfe opened this issue Dec 4, 2014 · 6 comments
Assignees
Labels

Comments

@Djfe
Copy link

Djfe commented Dec 4, 2014

Same as pockethub/PocketHub#495

I hope you can fix this, if you have time 👍

@jonan jonan self-assigned this Dec 5, 2014
@jonan jonan added the bug label Dec 5, 2014
@jonan
Copy link
Owner

jonan commented Dec 5, 2014

The duplicate bugs are appearing because the app is using a legacy API that isn't behaving properly. I've fixed this concrete issue but the real problem is the old API and that will take more time.

@jonan jonan closed this as completed Dec 5, 2014
@Djfe
Copy link
Author

Djfe commented Dec 5, 2014

Great! thx for the fix
I'm happy you forked the app and are now maintaining it the real way.
Maybe you could talk with Github and take over the official app ;)

btw. http://codehub-app.com/ is the best app I have seen so far for GitHub, it looks perfect and gives you all the details you need and it's optimized for tablets
it partially shows even a bit more than the website (event stream like the github app(everything that happened in a chronological order), but way better)
on Android there's only github.com/alorma/GitSkarios which I wasn't able to test because the log-in didn't work for me.

@ADTC
Copy link

ADTC commented Dec 5, 2014

Is there a new API and can it be updated to use the new API? I suspect that's a lot of work... how can we help?

Hopefully we can replicate CodeHub-like functionality in Android GitHub app (ForkHub) and make it even better.

@Djfe
Copy link
Author

Djfe commented Dec 5, 2014

actually most of the app's code needs to rewritten I guess
the app is like 2 or 3 api versions behind, there's a lot missing
-> you cannot see stuff like:
*got referenced by
*closed/reopened
*merged
*added/removed tags
etc.

and way more

EDIT:
some links about the apis
https://developer.github.com/v3/
https://www.apichangelog.com/api/github

@jonan
Copy link
Owner

jonan commented Dec 5, 2014

The app uses an external lib to access the API, but it uses a very old version of this lib.
I'll try to update the lib and see if we don't need many changes in the app.

@jonan
Copy link
Owner

jonan commented Dec 6, 2014

No luck, the lib is still using legacy API in it latest release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants