Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get.defaultDialog custom property never used in code. #3042

Open
anees4ever opened this issue Feb 28, 2024 · 1 comment
Open

Get.defaultDialog custom property never used in code. #3042

anees4ever opened this issue Feb 28, 2024 · 1 comment
Assignees

Comments

@anees4ever
Copy link

Describe the bug
Get.defaultDialog property 'custom' is never used in the code. So passing the argument does not deliver the expected output.

**Reproduction code
import 'package:get/get.dart';

Get.defaultDialog(
title: 'Loading the data...',
custom: const SizedBox(
height: 100,
width: 100,
child: Center(child: CircularProgressIndicator()),
),
barrierDismissible: false,
);

To Reproduce
Steps to reproduce the behavior:

  1. Run the above code
  2. See error: We expect the loading spinner to show on the dialog, but it will not display that. Only the title will be visible

Expected behavior
A dialog with title 'Loading the data....' and a rotating spinner.

Getx Version:
4.6.6

@anees4ever
Copy link
Author

If allowed, I can raise a pull request with a possible fix. I did it for my local project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants