Using Get.isDialogOpen is crashing the app #57
Comments
|
Using this same code that we used before, I can't get it to crash, BUT, import 'package:flutter/material.dart';
import 'package:get/get.dart';
import 'package:http/http.dart' as http;
class TestScreen extends StatelessWidget {
void login() {
getTestError();
getTestError();
}
Future<dynamic> getTestError() async {
final response =
await http.get('http://www.mocky.io/v2/5e97d4673000007900b6e08c');
if (response.statusCode == 200) {
return response.body;
} else {
print('error');
if (!Get.isDialogOpen) {
print('show error dialog');
await Get.defaultDialog(
title: 'Error',
content: Text('There was an error'),
confirm: FlatButton(
child: Text('OK'),
onPressed: () {
Get.back();
},
),
);
}
}
}
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: Container(
child: FlatButton(
child: Text('Test'),
onPressed: login,
),
),
),
);
}
}
|
GetMaterialApp(
initialRoute: '/login',
onGenerateRoute: Router.generateRoute, // update to namedRoutes.
// OnGenerateRoute is not working in the latest version of the master. Named routes are
// completely broken in Flutter, so I created this other API to do alternative work on it to make it work.
// navigatorObservers: [
// GetObserver(MiddleWare.observer),
// ],
routingCallback: MiddleWare.observer, // you dont need more from GetObserver
);I was looking at that at the time. And thinking about how I'm going to backport to Stable without regression. Flutter needs to update stable to urgent 1.17.0, the API for 1.12.0 is very limited. |
|
Using GetMaterialApp(
initialRoute: '/test',
onGenerateRoute: Router.generateRoute,
routingCallback: MiddleWare.observer,
); |
|
Okay, fixing the routes on the Master broke the onGenerateRoute on the Dev. If you used namedRoutes instead of onGenerateRoute, the error wouldn't appear, but either way, I'm going to reverse the fix on the Master and open an issue there, this should be fixed by them, definitely. |
|
2.0.5-dev will work to you |
|
ok, |
|
I can't for the life of me replicate outside my project... But do you have ANY idea why it COULD return null? I'm not sure what else to check. This is what I'm seeing on the Debugger:
|
|
Using GetMaterialApp, it is impossible for this value to return null, because from the first route, it already initializes with a value true/false. |
|
GetMaterialApp MaterialApp init route '/' Enable the logs and see if you find this reference as soon as the app starts: At the very moment that this log is written, Get.isDialogOpen receives false. If you saw this code in the log and Get.isDialogOpen returned null, it can only be a remnant of the old update. A quick way to confirm this is to use a widget from the same tile: Open a snackbar, and test Get.isSnackbarOpen instead of Get.isDialogOpen. The snackbar API has not changed, which means that it never failed, if it receives null too, the error is in the observer, if it receives true or false, the error is in remnants of old updates. |
|
I do see the log. Can you tell me where you are setting the initial |
|
Get.dialog is just a fullscreen page. Her name is 'dialog' by default (in the future I will give you the option to define the name of the dialog), and it is called as a normal named route internally. Who manages all this is the Routing class, which heard events from GetObserver. |
|
Ok, I think I found the issue. Looking for This is the code for void didReplace({Route newRoute, Route oldRoute}) {
super.didReplace(newRoute: newRoute, oldRoute: oldRoute);
if (Get.isLogEnable) print("[REPLACE ROUTE] ${oldRoute?.settings?.name}");
if (Get.isLogEnable) print("[NEW ROUTE] ${newRoute?.settings?.name}");
final routeSend = Routing(
removed: null, // add '${oldRoute?.settings?.name}' or remain null ???
isBack: false,
route: newRoute,
current: '${newRoute?.settings?.name}',
previous: '${oldRoute?.settings?.name}',
args: newRoute?.settings?.arguments,
isSnackbar: null,
isBottomSheet: null,
isDialog: null,
previousArgs: null);
if (routing != null) {
routing(routeSend);
}
Get.setRouting(routeSend);
}And in there all the snackbars, bottomSheet and dialog are being set to null. |
You got it! |
|
By the way, I also see the null setting on So in those 2 cases, Get.isDialogOpen will return null and crash the app |
|
I guess you don't need to set isDialog to false in there if it might bring other problems. But maybe you can do this instead? |
|
didRemove should not change the current status of a dialog, because you can open a dialog and remove a specific route (example, remove an ADS page if it is a payment dialog) if something happens in it for example, in which case the dialog will continue Open. |
|
That sounds like some extra work for you... in the meantime, FYI, doing this on static bool get isSnackbarOpen => _routing.isSnackbar ?? false;
/// check if dialog is open
static bool get isDialogOpen => _routing.isDialog ?? false;
/// check if bottomsheet is open
static bool get isBottomSheetOpen => _routing.isBottomSheet ?? false;Wether or not having dialogs as null in the library is needed, I think it is safe to assume that no dialog is open when it is set as null right?. So I think this is a clean and safe solution for this problem. What do you think? |
I thought about this approach, it works for substituted routes, but if someone in the future needs to remove a route that is not the current route, this may cause problems, so I modified GetObserver to not change these callbacks in case of removing a route. |
|
Not sure I understood that final logic, but, it works! |
This used to work before, but for some reason I am now getting a
Failed assertion: boolean expression must not be nullwhen callingif (Get.isDialogOpen)using
2.0.1-dev(I initially saw this on1.20.0-devbut upgraded to see if it would fix it)And this is my MaterialApp
I'm thinking it must be something on the latest 1.17.0-3.2pre since it's the only thing that changed before this broke
The text was updated successfully, but these errors were encountered: