Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow expires_at to be specified as UNIX timestamp #2

Merged
merged 3 commits into from
Nov 23, 2019
Merged

Allow expires_at to be specified as UNIX timestamp #2

merged 3 commits into from
Nov 23, 2019

Conversation

ctavan
Copy link
Contributor

@ctavan ctavan commented Nov 17, 2019

@ctavan ctavan mentioned this pull request Nov 17, 2019
Merged
jonathansamines
jonathansamines reviewed Nov 21, 2019
View reviewed changes
Copy link
Owner

@jonathansamines jonathansamines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good. Could we update the documentation to reflect the change in the configuration?

index.js Outdated Show resolved Hide resolved
@ctavan ctavan force-pushed the allow-unix-timestamp-for-expires-at branch from cecb77f to 256ae0a Compare November 23, 2019 12:50
@jonathansamines jonathansamines merged commit 9fd617c into jonathansamines:master Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathansamines jonathansamines jonathansamines left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctavan @jonathansamines