Allow expires_at to be a UNIX timestamp #277
Merged
+24
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library currently only handles expires_at properties well when they
are provided in ISOString representation.
Unlike the expires_in field, the expires_at is not part of the OAuth2
spec, so implementations may vary.
Some APIs like the Strava API use a UNIX timestamp (seconds since epoch)
in the expires_at field:
http://developers.strava.com/docs/authentication/#response-parameters-1
Token refresh will yield "Invalid Date" in the expires_at field when
only accepting an ISOString.
This patch checks if expires_at is a number and if so assumes it is a
UNIX timestamp (seconds since epoch).