Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency to #11

Closed
wants to merge 6 commits into from
Closed

Add dependency to #11

wants to merge 6 commits into from

Conversation

mummybot
Copy link
Contributor

From Readme: "To pass CSS @import files to a compiler (such as webpack), which would otherwise not know which CSS files to watch for browser reloading."

This resolves the request at #9. It is has been discussed at length at this Precss issue.

This code is based on the solution in postcss-import.

An indepth overview of the problem I was trying to solve.

@mummybot
Copy link
Contributor Author

If you think this is applicable, you may want to update the readme in postcss-partial-import to reflect usage for this plugin, and then use the example given here on the precss plugin readme.

@@ -138,11 +138,28 @@ The option if partials should be generated if they do not already exist.

#### `cachedir`

Type: `String`
Type: `String``

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mummybot There is an extra ` (tick) on line 141 that causes the README formatting to be wrong. There is also extra whitespace at the end of that line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I removed the extra mark. The extra space is to set it to add a line break to the readme, otherwise the properties are on one line.

Removed extra character
@jonathantneal
Copy link
Collaborator

Merged in 0f3993c Thanks!

@zpratt
Copy link

zpratt commented Mar 1, 2016

@jonathantneal any idea when you plan to release this?

@logankeenan
Copy link

I'm curious about a release as well.

@rybon
Copy link

rybon commented Jul 27, 2016

@jonathantneal will you update precss on npm to include this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants