Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a body is mapped, drop it down the list #79

Closed
joncage opened this issue Sep 3, 2020 · 4 comments · Fixed by #102
Closed

When a body is mapped, drop it down the list #79

joncage opened this issue Sep 3, 2020 · 4 comments · Fixed by #102
Labels
enhancement New feature or request

Comments

@joncage
Copy link
Owner

joncage commented Sep 3, 2020

No description provided.

@joncage joncage added the enhancement New feature or request label Sep 3, 2020
@ghost
Copy link

ghost commented Sep 19, 2020

Either drop it down the list or change the color of the "mappable" flag to green.

@joncage
Copy link
Owner Author

joncage commented Sep 19, 2020

Good call. Maybe switch it to a green tick (and drop it down the list)?

@joncage
Copy link
Owner Author

joncage commented Sep 28, 2020

Should just be a case of checking for events like this and looking up the body ID:

{ "timestamp":"2020-09-28T21:19:03Z", "event":"SAAScanComplete", "BodyName":"Wredguia GH-D d12-6 3", "SystemAddress":216501602667, "BodyID":4, "ProbesUsed":5, "EfficiencyTarget":6 }

If we find a match:

  1. set the unmapped flag colour like the landable style (colour-wise)
  2. change it's style to that of a discovered body
  3. move it to the top of the less valuable list.

@joncage
Copy link
Owner Author

joncage commented Sep 29, 2020

I have the bulk of this fixed I think but which looks better?

image

image

I think the latter is more consistent i.e. clearing the unmapped flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant