Test failing on Apple M1 due to float discrepancy > epsilon

[RJ]

I have a branch to fix a couple of places where assert_eq is changed to assert_relative_eq to make the tests pass on a mac M1.

This one I want to flag/query though - since it has a specific epsilon, and the difference in expected and observed values is much larger than the epsilon.

If this difference between left and right is within the acceptable range?
I could change the epsilon to make it pass? or change the epsilon just for apple-m1?
Seems weird it's such a large difference.

Anyway, happy to try and get all tests passing on m1 with a bit of guidance. thanks

The failing test:

        assert_relative_eq!(
            mass_props.mass.0,
            original_mass_props.mass.0,
            epsilon = 0.000_001
        );

output from cargo test:

failures:

---- components::world_queries::tests::mass_properties_add_sub_works stdout ----
thread 'components::world_queries::tests::mass_properties_add_sub_works' panicked at 'assert_relative_eq!(mass_props.mass.0, original_mass_props.mass.0, epsilon = 0.000_001)

    left  = 15.642822
    right = 15.6427965

', crates/bevy_xpbd_2d/../../src/components/world_queries.rs:257:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    components::world_queries::tests::mass_properties_add_sub_works

[Jondolf]

You can just make the epsilon larger to make it pass. It's weird that the difference is that large though, because that particular test just does mass_a + mass_b - mass_b == mass_a. It also works on Windows and Ubuntu (my PC and CI).