Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semver break in 0.10.13 #233

Closed
c-nixon opened this issue Mar 3, 2022 · 1 comment
Closed

Semver break in 0.10.13 #233

c-nixon opened this issue Mar 3, 2022 · 1 comment

Comments

@c-nixon
Copy link

c-nixon commented Mar 3, 2022

We happen to have cargo-flamegraph building in a part of our CI and have just started receiving the following error

    --> /opt/rust/cargo/registry/src/github.com-1ecc6299db9ec823/flamegraph-0.5.1/src/lib.rs:299:43
     |
 299 |             collapse_options.skip_after = Some(skip_after.into())
     |             ---------------------------   ^^^^^^^^^^^^^^^^^^^^^^^ expected struct `Vec`, found enum `Option`
     |             |
     |             expected due to the type of this binding
     |
     = note: expected struct `Vec<String>`
                  found enum `Option<_>`

It looks like it has "0.10.8" as the version in it's Cargo.toml

@jonhoo
Copy link
Owner

jonhoo commented Mar 3, 2022

Ah yes, you're totally right! #231 is backwards incompatible for the library. I keep forgetting about that! I've yanked 0.10.13 and released as 0.11.0.

@jonhoo jonhoo closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants