Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rspec: 1.42.0 → 1.43.1 (minor) #210

Merged
merged 2 commits into from
Aug 18, 2020

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Aug 18, 2020

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (1.42.0 → 1.43.1) · Repo · Changelog

Release Notes

1.43.1

Fix RSpec/FilePath when checking a file defining e.g. an empty class. (@bquorning)

1.43.0

  • Add a new base cop class ::RuboCop::Cop::RSpec::Base. The old base class ::RuboCop::Cop::RSpec::Cop is deprecated, and will be removed in the next major release. (@bquorning)
  • Add support for subject detection after includes and example groups in RSpec/LeadingSubject. (@pirj)
  • Ignore trailing punctuation in context description prefix. (@elliterate)
  • Relax RSpec/VariableDefinition cop so interpolated and multiline strings are accepted even when configured to enforce the symbol style. (@bquorning)
  • Fix RSpec/EmptyExampleGroup to flag example groups with examples in invalid scopes. (@mlarraz)
  • Fix RSpec/EmptyExampleGroup to ignore examples groups with examples defined inside iterators. (@pirj)
  • Improve RSpec/NestedGroups, RSpec/FilePath, RSpec/DescribeMethod, RSpec/MultipleDescribes, RSpec/DescribeClass's top-level example group detection. (@pirj)
  • Add detection of let! with a block-pass or a string literal to RSpec/LetSetup. (@pirj)
  • Add IgnoredPatterns configuration option to RSpec/VariableName. (@jtannas)
  • Add RSpec/MultipleMemoizedHelpers cop. (@mockdeep)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Aug 18, 2020
@jonhue jonhue merged commit f452e56 into master Aug 18, 2020
@jonhue jonhue deleted the depfu/update/rubocop-rspec-1.43.1 branch August 18, 2020 12:47
@jonhue jonhue mentioned this pull request Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant