feat(core): make DependencyAttribute's implementation argument optional #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no implementation is given, it is expected to be the same as the dependency. This should make it easier to declare concrete dependencies i.e. `[Dependency(typeof(CounterService))]`.
jonisavo
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 55 55
Lines 1656 1658 +2
=========================================
+ Hits 1656 1658 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
…al (#109) If no implementation is given, it is expected to be the same as the dependency. This should make it easier to declare concrete dependencies i.e. `[Dependency(typeof(CounterService))]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no implementation is given, it is expected to be the same as the dependency. This should make it easier to declare concrete dependencies i.e.
[Dependency(typeof(CounterService))].This resolves part of #104.