Fix #1124: A User is unable to reduce the size of a Resize node after plugging the resize with Y.Plugin.ResizeProxy #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or groups. removing legacy /build segment from the default CDN path
…both *timeout* and *failure* are defined. Fixes yui#1817 [stanleyhlng]
Conflicts: bower.json build/yui-nodejs/yui-nodejs-min.js build/yui/yui-min.js package.json
Conflicts: bower.json build/yui-base/yui-base-coverage.js build/yui-core/yui-core-coverage.js build/yui-nodejs/yui-nodejs-coverage.js build/yui-nodejs/yui-nodejs-min.js build/yui/yui-coverage.js build/yui/yui-min.js package.json
Conflicts: build/yui-nodejs/yui-nodejs-min.js build/yui/yui-min.js
Add editor regression fix.
modified: bower.json modified: package.json
Conflicts: src/handlebars/HISTORY.md
modified: ../build/editor-selection/editor-selection-coverage.js modified: ../build/editor-selection/editor-selection-debug.js modified: ../build/editor-selection/editor-selection-min.js modified: ../build/editor-selection/editor-selection.js
…ice-configfn-bugfix
Conflicts: build/loader-base/loader-base-coverage.js build/loader-base/loader-base-min.js build/loader-pathogen-encoder/loader-pathogen-encoder-min.js build/loader/loader-min.js build/yui-nodejs/yui-nodejs-min.js build/yui/yui-min.js
Conflicts: src/loader/HISTORY.md src/yui/HISTORY.md
…fter plugging the resize with Y.Plugin.ResizeProxy
|
Merged and sent to @eduardolundgren and @mairatma for final review. New Pull Request: https://github.com/eduardolundgren/yui3/pull/35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jonmak08,
This fixes the issue described in yui#1124. Before shimming is added to ddm, the mousemove events are listened by
docandshim. When mouse is on top of the resize proxy, the mouse event can still be caught bydocwhen shim is covered by the resize proxy. After yui@36a51b7 is pushed in, mousemove can only be caught byshimwhenuseShimis enabled. And since resize proxy has higher z-index than shim, the mousemove can't be caught when we drag the resize handle over proxy.So to fix this, I just give the shim a higher z-index. We can also change the z-index of the resize proxy, but like you said it's probably set for something. It's safer to change the z-index of the shim since the purpose of the shim is to track the mousemove events on the screen.Let me know if there are any issues. Thanks!