-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start button disappears #3
Comments
Oh interesting this looks quite similar to issue #2 - possibly a duplicate. As of yet I've been unable to properly reproduce this. Both of you seem to be using a dark theme - I wonder if that that's what's causing the issue. Can you tell me how you got the dark theme? |
Its a userstyle called wanikani dark that i use with stylish. I tried disabling it before sending this error too, but that didn't change anything |
I need to find out for definite if the widget is being created and exists in the DOM. It's possible it's there and is just incorrectly styled (somehow). I've made a separate branch which should log a lot of stuff out to the console. If you don't mind, could you uninstall your current version and install from here: Once you've done that, can you go to https://www.wanikani.com/dashboard, open the console up (F12) and copy out what you get? There should be a bunch of stuff starting with "WKBurnReview: " I appreciate it's hassle but given that I can't reproduce this error, I don't have many other options to debug it. |
This is what i got from console, hope this helps to determine where the started Wanikani Dashboard Active Topics Panel On Thu, Jun 9, 2016 at 10:47 AM, Jonny Dark notifications@github.com
|
Thanks! Ok I think I know what's going wrong. Basically the code has failed to get your wanikani data and is failing ungracefully. I was able to reproduce your issue by using an invalid API key. The original maintainer of this plugin didn't put in sufficient error checking to confirm that it was able to actually get the data. Also the fact that you have to edit and put in your API key to get it working is absurd. This is something I will fix in a future update. In order to get this up and running and working for you right now though, do the following:
If that doesn't work, then just wait until I've fixed the code to handle these errors better :) |
well that fucked up my settings i changed with other scripts, like the thanks On Fri, Jun 10, 2016 at 2:02 PM, Jonny Dark notifications@github.com
|
Oh shit! I'm really sorry! I should have warned you about that! I hope it isn't too much hassle :/ What had happened was that it had somehow got the wrong API key and had built up a cache of burnt that was empty. Because the cache was empty it couldn't display the widget, but because the cache existed, it didn't bother trying to update ever again. It's stupidly written and it's on my list of things to fix. I'll close this ticket when I've fixed this particular issue :) Thankyou for helping debug this script and again, apologies for messing up your other scripts. |
Ah dont worry too much, it was a good excuse for me to update my gif and On Fri, Jun 10, 2016 at 9:43 PM, Jonny Dark notifications@github.com
|
Well shit, I just realised I've ruined that one for myself too.... On Fri, Jun 10, 2016 at 8:51 PM, Amenophyckxs notifications@github.com
|
:D On Fri, Jun 10, 2016 at 9:59 PM, Jonny Dark notifications@github.com
|
this is probably useless info, but just letting you know to remove any doubt. I disabled the bugfix version and reinstalled the normal version and that works fine now too, aside from a new bug i found (in both versions) for which i made a new issue :) |
Ah good, that's what I would have expected. The fact the cache got in to
|
Confirmed this is a duplicate of issue #2 |
When i open the dashboard, i see the window appear with "start" in the middle and then half a second later, the window collapses and the "start" disappears.
I'm left with this: http://prntscr.com/bbni2g
i have tried to disable all other userscripts one by one, but that did not fix it.
on windows 10 - chrome 50.0.2661.102 m (64-bit)
The text was updated successfully, but these errors were encountered: