Async method calling a dependency synchronously?

[nelsonic]

Hi @jonschlinkert, hope you are well.

While trying out this module, we noticed that you are calling your is-directory module's isDir method (without a callback) in the dirs (async) method on line 31:

dirs/index.js

Line 31 in c90b488

if (isDir(filepath)) {

am I missing something...?
Thanks!

[jonschlinkert]

nope you're right. initially is-directory was sync only: jonschlinkert/is-directory@8989e5e. Looks like I did both on the same day and forgot to circle back to this lib to update for async.

thanks for the heads up!

[jonschlinkert]

actually, yes, I forgot about this until I pulled it down:

dirs/index.js

Lines 14 to 16 in c90b488

	if (typeof cb !== 'function') {
	return dirs.sync(dir);
	}

.

If no callback is passed, it calls the sync function. closing this since it's not a bug here. but, it's arguably not a good idea since we both missed it. which would make it an issue on the other lib. thanks for the feedback