Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not generating number #23

Closed
markl-vesper opened this issue May 17, 2019 · 1 comment
Closed

not generating number #23

markl-vesper opened this issue May 17, 2019 · 1 comment

Comments

@markl-vesper
Copy link

Hi

Just started using this package. Looks nice

Used ('Aa0!', 10) as the options and the password returned was eVs)ho=pZ; which is failing to include a number.

Is the pattern simply what the generater 'could' include when generating the password and not 'must' include perhaps?

Wondering how it ended up generating a string without a number.......

Thanks

@doowb
Copy link
Collaborator

doowb commented May 17, 2019

Is the pattern simply what the generater 'could' include when generating the password and not 'must' include perhaps?

Correct. Given the list of characters to choose from, random characters are chosen up to the provided length.

Wondering how it ended up generating a string without a number.......

Since randomatic randomly chooses characters from the list, there's not guarantee that characters from specific groups will be chosen. Also, it looks like you're using randomatic as a password generator, but that's not randomatic's only use case. This gives developers like you the ability to build specific implementations using randomatic for specific user cases.

I'm not sure exactly what the code looks like, but I can envision a function that calls randomatic multiple times given different character groups to ensure characters are included. This would be useful for a password generator since you can provide it with the rules for what must be in a password.

I'm going close this, but if you run into any bugs while using randomatic, please feel free to open a new issue. If you have an additional questions, feel free to continue the discussion on this issue.

@doowb doowb closed this as completed May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants