Use named exports for public api #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default exports are always a headache for public api. They are hard to use when same module is used for both node and webpack via commonjs. We have this problem webpack/webpack#6584 Mixing named and default exports works even buggier. webpack/webpack#7973 The best solution is using only named exports. They fits perfectly with interops and may work without interop for commonjs. (module.exports = was a mistake, export default IMO too)
doowb
approved these changes
Aug 6, 2019
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default exports are always a headache for public api. They are hard to
use when same module is used for both node and webpack via commonjs.
We have this problem
webpack/webpack#6584
Mixing named and default exports works even buggier.
webpack/webpack#7973
The best solution is using only named exports. They fits perfectly with
interops and may work without interop for commonjs.
(module.exports = was a mistake, export default IMO too)