Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs redo #180

Merged
merged 29 commits into from
Jul 24, 2021
Merged

Tabs redo #180

merged 29 commits into from
Jul 24, 2021

Conversation

dgrammatiko
Copy link
Collaborator

@dgrammatiko dgrammatiko commented Jul 16, 2021

Fixing what's broken

  • Rewritten so there are no more moving elements in the DOM
  • Added breakpoint attribute to control the transition from tabs to accordion and vice versa
  • Tab elements are moved from section to joomla-tab-element (mildly B/C break)
  • Tabs container element renamed from joomla-tab to joomla-tabs (mildly B/C break) nope

A11y based on
https://www.w3.org/TR/wai-aria-practices-1.1/examples/accordion/accordion.html
and
https://www.w3.org/TR/wai-aria-practices-1.1/examples/tabs/tabs-1/tabs.html

Docs, preview:
Screenshot 2021-07-17 at 14 37 44

@richard67
Copy link

@dgrammatiko Is the "WIP" at the top of the description still true?

@dgrammatiko
Copy link
Collaborator Author

@richard67 There's one change pending (I got something wrong), will update it shortly

@richard67
Copy link

@wilsonge As the CMS PR #34813 using the last commit here has received 2 successful tests, can we get this one here merged and a new tag or release being made, so PR #34813 can be updated to use that?

@dgrammatiko
Copy link
Collaborator Author

@wilsonge if you're ok with this please make a patch release (0.2.0) to keep things whithin SEMVER

@Bakual
Copy link

Bakual commented Jul 24, 2021

Actually, it should become 1.0.0 since we're going to use it in production. 0.x.x releases are not meant to be used in production.

See https://semver.org/#spec-item-4

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

@wilsonge wilsonge merged commit 8c056ba into joomla-projects:master Jul 24, 2021
@wilsonge
Copy link
Contributor

I’m not at home right now so will do the release later. But Thankyou!

@dgrammatiko dgrammatiko deleted the tabs branch July 24, 2021 17:43
@dgrammatiko
Copy link
Collaborator Author

I need to fix the saucelabs tests to fire without the label attach procedure.

Thanks

@wilsonge
Copy link
Contributor

Released

@bembelimen
Copy link
Contributor

Sorry to be late for the party: thanks for the rebuild @dgrammatiko the tabs are very cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants