-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs redo #180
Tabs redo #180
Conversation
rename `section` to `joomla-tab-element`
@dgrammatiko Is the "WIP" at the top of the description still true? |
@richard67 There's one change pending (I got something wrong), will update it shortly |
@wilsonge As the CMS PR #34813 using the last commit here has received 2 successful tests, can we get this one here merged and a new tag or release being made, so PR #34813 can be updated to use that? |
@wilsonge if you're ok with this please make a patch release (0.2.0) to keep things whithin SEMVER |
Actually, it should become 1.0.0 since we're going to use it in production. 0.x.x releases are not meant to be used in production. See https://semver.org/#spec-item-4
|
I’m not at home right now so will do the release later. But Thankyou! |
I need to fix the saucelabs tests to fire without the label attach procedure. Thanks |
Released |
Sorry to be late for the party: thanks for the rebuild @dgrammatiko the tabs are very cool. |
Fixing what's broken
breakpoint
attribute to control the transition from tabs to accordion and vice versasection
tojoomla-tab-element
(mildly B/C break)Tabs container element renamed fromnopejoomla-tab
tojoomla-tabs
(mildly B/C break)A11y based on
https://www.w3.org/TR/wai-aria-practices-1.1/examples/accordion/accordion.html
and
https://www.w3.org/TR/wai-aria-practices-1.1/examples/tabs/tabs-1/tabs.html
Docs, preview: