SQL - improve CAST with CAST('field' AS CHAR(n)) (#12417)

* SQL - improve CAST('field' AS CHAR(n))

SQL - improve CAST('field' AS CHAR(n))

* SQL - improve CAST('field' AS CHAR(n))

SQL - improve CAST('field' AS CHAR(n))

* moved castAsChar to the driver

moved castAsChar to the driver

* CAST with CAST('field' AS CHAR(n))

CAST with CAST('field' AS CHAR(n))

* tab

tab

* tabs again

tabs again

* re-added castAsChar()

re-added castAsChar() as per comment

* travis cs fix

travis cs fix

* the mssql castAsChar()

the mssql castAsChar()

* msdn

msdn

libraries/joomla/database/query/mysqli.php

@@ -201,4 +201,33 @@ public function selectRowNumber($orderBy, $orderColumnAlias)
 
 		return $this;
 	}
+
+	/**
+	 * Casts a value to a char.
+	 *
+	 * Ensure that the value is properly quoted before passing to the method.
+	 *
+	 * Usage:
+	 * $query->select($query->castAsChar('a'));
+	 * $query->select($query->castAsChar('a', 40));
+	 *
+	 * @param   string  $value  The value to cast as a char.
+	 *
+	 * @param   string  $len    The lenght of the char.
+	 *
+	 * @return  string  Returns the cast value.
+	 *
+	 * @since   3.7.0
+	 */
+	public function castAsChar($value, $len = null)
+	{
+		if (!$len)
+		{
+			return $value;
+		}
+		else
+		{
+			return ' CAST(' . $value . ' AS CHAR(' . $len . '))';
+		}
+	}
 }

libraries/joomla/database/query/pdo.php

@@ -16,4 +16,32 @@
  */
 class JDatabaseQueryPdo extends JDatabaseQuery
 {
+	/**
+	 * Casts a value to a char.
+	 *
+	 * Ensure that the value is properly quoted before passing to the method.
+	 *
+	 * Usage:
+	 * $query->select($query->castAsChar('a'));
+	 * $query->select($query->castAsChar('a', 40));
+	 *
+	 * @param   string  $value  The value to cast as a char.
+	 *
+	 * @param   string  $len    The lenght of the char.
+	 *
+	 * @return  string  Returns the cast value.
+	 *
+	 * @since   11.1
+	 */
+	public function castAsChar($value, $len = null)
+	{
+		if (!$len)
+		{
+			return $value;
+		}
+		else
+		{
+			return ' CAST(' . $value . ' AS CHAR(' . $len . '))';
+		}
+	}
 }

libraries/joomla/database/query/postgresql.php

@@ -335,16 +335,26 @@ public function clear($clause = null)
 	 *
 	 * Usage:
 	 * $query->select($query->castAsChar('a'));
+	 * $query->select($query->castAsChar('a', 40));
 	 *
 	 * @param   string  $value  The value to cast as a char.
 	 *
+	 * @param   string  $len    The lenght of the char.
+	 *
 	 * @return  string  Returns the cast value.
 	 *
 	 * @since   11.3
 	 */
-	public function castAsChar($value)
+	public function castAsChar($value, $len = null)
 	{
-		return $value . '::text';
+		if (!$len)
+		{
+			return $value . '::text';
+		}
+		else
+		{
+			return ' CAST(' . $value . ' AS CHAR(' . $len . '))';
+		}
 	}
 
 	/**

libraries/joomla/database/query/sqlsrv.php

@@ -233,15 +233,24 @@ public function __toString()
 	 *
 	 * Ensure that the value is properly quoted before passing to the method.
 	 *
-	 * @param   string  $value  The value to cast as a char.
+	 * @param   string  $value  The value to cast as a char.	 
+	 *
+	 * @param   string  $len    The lenght of the char.
 	 *
 	 * @return  string  Returns the cast value.
 	 *
 	 * @since   11.1
 	 */
-	public function castAsChar($value)
+	public function castAsChar($value, $len = null)
 	{
-		return 'CAST(' . $value . ' as NVARCHAR(10))';
+		if(!$len)
+		{			
+			return 'CAST(' . $value . ' as NVARCHAR(30))';
+		}
+		else
+		{
+			return 'CAST(' . $value . ' as NVARCHAR(' . $len . '))';
+		}
 	}
 
 	/**