SQL - improve CAST with CAST('field' AS CHAR(n))

[alikon]

as per comment on #12348 see #12348 (review)

Summary of Changes

• implemented missing feature for SQL CAST CAST('field' AS CHAR(n))
• moved the castAsChar() from query.php to each driver

Testing Instructions

this kind of CAST works now
$query->select($query->castAsChar('field', 40))
$query->select($query->castAsChar('field'))

Documentation Changes Required

we can use this type of SQL too
$query->select($query->castAsChar('field', 40))

[mbabker]

You need to keep the base function in JDatabaseQuery otherwise if it's used with a subclass not implementing the method you'll end up with a fatal error. Otherwise aside from the CI failures seems fine to me.

[alikon]

restored castAsChar() in JDatabaseQuery as suggested

[waader]

I have tested this item ✅ successfully on c5711ba

Tested with mysql and postgresql. Thanks!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12417.}

[jeckodevelopment]

@alikon Nicola, can you please check the conflicting file?
libraries/joomla/database/query/mysqli.php

[alikon]

conflict fixed

[waader]

The mssql implementation is missing here.

[alikon]

@waader added the mssql part

[csthomas]

Can you change default len for mssql from 10 to 30.

https://msdn.microsoft.com/en-us/library/ms187928.aspx

The default value is 30.

It would be useful for datetime2 which has 19 chars. 0000-00-00 00:00:00

[waader]

@alikon: is this ready for testing?

[alikon]

yes now fixed last comment from @csthomas about mssql

[waader]

I have tested this item ✅ successfully on a3bad12

Thanks!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12417.}

[csthomas]

I have tested this item ✅ successfully on a3bad12

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12417.}

[jeckodevelopment]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12417.}

[wilsonge]

@alikon Would you mind porting this to the framework package so that it can go into the 4.x branch please - I just realised it's gone missing (issue to track this on framework at joomla-framework/database#157)

[alikon]

went out of my radar i'll try to add #18961 then too