Don't echo bdi element if it can be used directly in markup

joomla · Oct 17, 2021 · 6c35602 · 6c35602
1 parent 811a59c
commit 6c35602
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/administrator/components/com_installer/views/languages/tmpl/default.php b/administrator/components/com_installer/views/languages/tmpl/default.php
@@ -83,9 +83,9 @@
 								<?php $minorVersion = $version::MAJOR_VERSION . '.' . $version::MINOR_VERSION; ?>
 								<?php // Display a Note if language pack version is not equal to Joomla version ?>
 								<?php if (strpos($language->version, $minorVersion) !== 0 || strpos($language->version, $currentShortVersion) !== 0) : ?>
-									<span class="label label-warning hasTooltip" title="<?php echo JText::_('JGLOBAL_LANGUAGE_VERSION_NOT_PLATFORM'); ?>"><?php echo '<bdi>' . $language->version . '</bdi>'; ?></span>
+									<span class="label label-warning hasTooltip" title="<?php echo JText::_('JGLOBAL_LANGUAGE_VERSION_NOT_PLATFORM'); ?>"><bdi><?php echo $language->version; ?></bdi></span>
 								<?php else : ?>
-									<span class="label label-success"><?php echo '<bdi>' . $language->version . '</bdi>'; ?></span>
+									<span class="label label-success"><bdi><?php echo $language->version; ?></bdi></span>
 								<?php endif; ?>
 						</td>
 						<td class="small hidden-phone">

diff --git a/administrator/components/com_installer/views/update/tmpl/default.php b/administrator/components/com_installer/views/update/tmpl/default.php
@@ -105,10 +105,10 @@
 									<?php echo $item->type_translated; ?>
 								</td>
 								<td class="hidden-phone center">
-									<span class="label label-warning"><?php echo '<bdi>' . $item->current_version . '</bdi>'; ?></span>
+									<span class="label label-warning"><bdi><?php echo $item->current_version; ?></bdi></span>
 								</td>
 								<td class="center">
-									<span class="label label-success"><?php echo '<bdi>' . $item->version . '</bdi>'; ?></span>
+									<span class="label label-success"><bdi><?php echo $item->version; ?></bdi></span>
 								</td>
 								<td class="hidden-phone center">
 									<?php echo $item->folder_translated; ?>

diff --git a/administrator/components/com_joomlaupdate/views/default/tmpl/default_update.php b/administrator/components/com_joomlaupdate/views/default/tmpl/default_update.php
@@ -26,15 +26,15 @@
 				<?php echo JText::_('COM_JOOMLAUPDATE_VIEW_DEFAULT_INSTALLED'); ?>
 			</td>
 			<td>
-				<?php echo '<bdi>' . $this->updateInfo['installed'] . '</bdi>'; ?>
+				<bdi><?php echo $this->updateInfo['installed']; ?></bdi>
 			</td>
 		</tr>
 		<tr>
 			<td>
 				<?php echo JText::_('COM_JOOMLAUPDATE_VIEW_DEFAULT_LATEST'); ?>
 			</td>
 			<td>
-				<?php echo '<bdi>' . $this->updateInfo['latest'] . '</bdi>'; ?>
+				<bdi><?php echo $this->updateInfo['latest']; ?></bdi>
 			</td>
 		</tr>
 		<tr>

diff --git a/administrator/components/com_languages/views/installed/tmpl/default.php b/administrator/components/com_languages/views/installed/tmpl/default.php
@@ -103,9 +103,9 @@
 					<?php $minorVersion = $version::MAJOR_VERSION . '.' . $version::MINOR_VERSION; ?>
 					<?php // Display a Note if language pack version is not equal to Joomla version ?>
 					<?php if (strpos($row->version, $minorVersion) !== 0 || strpos($row->version, $currentShortVersion) !== 0) : ?>
-						<span class="label label-warning hasTooltip" title="<?php echo JText::_('JGLOBAL_LANGUAGE_VERSION_NOT_PLATFORM'); ?>"><?php echo '<bdi>' . $row->version . '</bdi>'; ?></span>
+						<span class="label label-warning hasTooltip" title="<?php echo JText::_('JGLOBAL_LANGUAGE_VERSION_NOT_PLATFORM'); ?>"><bdi><?php echo $row->version; ?></bdi></span>
 					<?php else : ?>
-						<span class="label label-success"><?php echo '<bdi>' . $row->version . '</bdi>'; ?></span>
+						<span class="label label-success"><bdi><?php echo $row->version; ?></bdi></span>
 					<?php endif; ?>
 					</td>
 					<td class="hidden-phone">