Browse files

Fixed issue [#21247] HTML comments shouldn't be used to guard JavaScr…

…ipt (Rouven Weßling).

git-svn-id: http://joomlacode.org/svn/joomla/development/trunk@18204 6f6e1ebd-4c2b-0410-823f-f34bde69bce9
  • Loading branch information...
1 parent a2c6344 commit 78198498d936c0a1e8f9a2367f186404ba4a3a06 @eddieajau eddieajau committed Jul 22, 2010
Showing with 9 additions and 121 deletions.
  1. +0 −2 administrator/components/com_banners/views/banner/tmpl/edit.php
  2. +0 −2 administrator/components/com_banners/views/client/tmpl/edit.php
  3. +0 −2 administrator/components/com_banners/views/download/tmpl/default.php
  4. +0 −2 administrator/components/com_categories/views/category/tmpl/edit.php
  5. +0 −2 administrator/components/com_config/views/application/tmpl/default.php
  6. +0 −2 administrator/components/com_config/views/component/tmpl/default.php
  7. +0 −2 administrator/components/com_contact/views/contact/tmpl/edit.php
  8. +0 −2 administrator/components/com_content/views/article/tmpl/edit.php
  9. +0 −2 administrator/components/com_installer/views/install/tmpl/default_form.php
  10. +0 −2 administrator/components/com_languages/views/language/tmpl/edit.php
  11. +0 −2 administrator/components/com_menus/views/menu/tmpl/edit.php
  12. +0 −2 administrator/components/com_menus/views/menus/tmpl/default.php
  13. +0 −2 administrator/components/com_messages/views/config/tmpl/default.php
  14. +0 −2 administrator/components/com_messages/views/message/tmpl/edit.php
  15. +0 −2 administrator/components/com_modules/models/fields/moduleorder.php
  16. +0 −2 administrator/components/com_modules/views/module/tmpl/edit.php
  17. +0 −2 administrator/components/com_modules/views/module/tmpl/modal.php
  18. +0 −2 administrator/components/com_newsfeeds/views/newsfeed/tmpl/edit.php
  19. +0 −2 administrator/components/com_plugins/views/plugin/tmpl/edit.php
  20. +0 −2 administrator/components/com_redirect/views/link/tmpl/edit.php
  21. +0 −2 administrator/components/com_templates/views/source/tmpl/edit.php
  22. +0 −2 administrator/components/com_templates/views/style/tmpl/edit.php
  23. +0 −2 administrator/components/com_users/views/group/tmpl/edit.php
  24. +0 −2 administrator/components/com_users/views/level/tmpl/edit.php
  25. +0 −2 administrator/components/com_users/views/user/tmpl/edit.php
  26. +0 −2 administrator/components/com_weblinks/views/weblink/tmpl/edit.php
  27. +0 −2 administrator/templates/hathor/html/com_categories/category/edit.php
  28. +0 −2 administrator/templates/hathor/html/com_content/article/edit.php
  29. +0 −2 administrator/templates/hathor/html/com_menus/item/edit.php
  30. +0 −2 administrator/templates/hathor/html/com_menus/menu/edit.php
  31. +0 −2 administrator/templates/hathor/html/com_menus/menus/default.php
  32. +0 −2 administrator/templates/hathor/html/com_modules/module/edit.php
  33. +0 −2 administrator/templates/hathor/html/com_modules/module/modal.php
  34. +0 −2 administrator/templates/hathor/html/com_newsfeeds/newsfeed/edit.php
  35. +0 −2 administrator/templates/hathor/html/com_plugins/plugin/edit.php
  36. +0 −2 administrator/templates/hathor/html/com_weblinks/weblink/edit.php
  37. +2 −3 components/com_contact/views/contact/tmpl/default_form.php
  38. +0 −2 components/com_mailto/views/mailto/tmpl/default.php
  39. +2 −0 installation/CHANGELOG
  40. +0 −3 installation/gpl.html
  41. +0 −3 installation/migration.html
  42. +0 −2 installation/views/complete/tmpl/default.php
  43. +0 −2 installation/views/database/tmpl/default.php
  44. +0 −2 installation/views/filesystem/tmpl/default.php
  45. +0 −2 installation/views/language/tmpl/default.php
  46. +0 −2 installation/views/license/tmpl/default.php
  47. +0 −2 installation/views/preinstall/tmpl/default.php
  48. +0 −2 installation/views/site/tmpl/default.php
  49. +3 −9 libraries/joomla/document/html/renderer/head.php
  50. +2 −3 templates/rhuk_milkyway/_html/com_contact/contact/default_form.php
  51. +0 −2 templates/rhuk_milkyway/_html/com_content/article/form.php
  52. +0 −2 templates/rhuk_milkyway/_html/com_mailto/mailto/default.php
  53. +0 −2 templates/rhuk_milkyway/_html/com_mailto/sent/default.php
  54. +0 −2 templates/rhuk_milkyway/_html/com_newsfeeds/categories/default.php
  55. +0 −2 templates/rhuk_milkyway/_html/com_user/register/default.php
  56. +0 −2 templates/rhuk_milkyway/_html/com_user/user/form.php
View
2 administrator/components/com_banners/views/banner/tmpl/edit.php
@@ -15,7 +15,6 @@
JHtml::_('behavior.formvalidation');
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'banner.cancel' || document.formvalidator.isValid(document.id('banner-form'))) {
@@ -39,7 +38,6 @@ function submitbutton(task)
document.id('jform_type1').fireEvent('click');
}
});
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_banners'); ?>" method="post" name="adminForm" id="banner-form" class="form-validate">
View
2 administrator/components/com_banners/views/client/tmpl/edit.php
@@ -15,14 +15,12 @@
JHtml::_('behavior.formvalidation');
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'client.cancel' || document.formvalidator.isValid(document.id('client-form'))) {
submitform(task);
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_banners'); ?>" method="post" name="adminForm" id="client-form" class="form-validate">
View
2 administrator/components/com_banners/views/download/tmpl/default.php
@@ -12,7 +12,6 @@
JHtml::_('behavior.tooltip');
?>
<script type="text/javascript">
-<!--
window.addEvent('domready', function() {
document.id('jform_compressed1').addEvent('click', function(e){
document.id('jform_inline0').checked=false;
@@ -23,7 +22,6 @@
document.id('jform_compressed1').checked=false;
});
});
-// -->
</script>
<form
action="<?php echo JRoute::_('index.php?option=com_banners&task=tracks.display&format=raw');?>"
View
2 administrator/components/com_categories/views/category/tmpl/edit.php
@@ -21,7 +21,6 @@
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'category.cancel' || document.formvalidator.isValid(document.id('item-form'))) {
@@ -32,7 +31,6 @@ function submitbutton(task)
alert('<?php echo $this->escape(JText::_('JGLOBAL_VALIDATION_FORM_FAILED'));?>');
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_menus'); ?>" method="post" name="adminForm" id="item-form" class="form-validate">
View
2 administrator/components/com_config/views/application/tmpl/default.php
@@ -20,14 +20,12 @@
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'application.cancel' || document.formvalidator.isValid(document.id('application-form'))) {
submitform(task);
}
}
--->
</script>
<form action="<?php echo JRoute::_('index.php?option=com_config');?>" id="application-form" method="post" name="adminForm" class="form-validate">
View
2 administrator/components/com_config/views/component/tmpl/default.php
@@ -17,14 +17,12 @@
JHtml::_('behavior.formvalidation');
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (document.formvalidator.isValid(document.id('component-form'))) {
submitform(task);
}
}
--->
</script>
<form action="<?php echo JRoute::_('index.php?option=com_config');?>" id="component-form" method="post" name="adminForm" autocomplete="off" class="form-validate">
<fieldset>
View
2 administrator/components/com_contact/views/contact/tmpl/edit.php
@@ -16,7 +16,6 @@
JHtml::_('behavior.formvalidation');
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'contact.cancel' || document.formvalidator.isValid(document.id('contact-form'))) {
@@ -27,7 +26,6 @@ function submitbutton(task)
alert('<?php echo $this->escape(JText::_('JGLOBAL_VALIDATION_FORM_FAILED'));?>');
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_contact'); ?>" method="post" name="adminForm" id="contact-form" class="form-validate">
View
2 administrator/components/com_content/views/article/tmpl/edit.php
@@ -19,7 +19,6 @@
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'article.cancel' || document.formvalidator.isValid(document.id('item-form'))) {
@@ -30,7 +29,6 @@ function submitbutton(task)
alert('<?php echo $this->escape(JText::_('JGLOBAL_VALIDATION_FORM_FAILED'));?>');
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_content'); ?>" method="post" name="adminForm" id="item-form" class="form-validate">
View
2 administrator/components/com_installer/views/install/tmpl/default_form.php
@@ -12,7 +12,6 @@
defined('_JEXEC') or die;
?>
<script type="text/javascript">
-<!--
function submitbutton3(pressbutton) {
var form = document.adminForm;
@@ -36,7 +35,6 @@ function submitbutton4(pressbutton) {
form.submit();
}
}
-//-->
</script>
<form enctype="multipart/form-data" action="<?php echo JRoute::_('index.php?option=com_installer&view=install');?>" method="post" name="adminForm">
View
2 administrator/components/com_languages/views/language/tmpl/edit.php
@@ -15,14 +15,12 @@
JHtml::_('behavior.formvalidation');
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'language.cancel' || document.formvalidator.isValid(document.id('language-form'))) {
submitform(task);
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_languages'); ?>" method="post" name="adminForm" id="language-form" class="form-validate">
View
2 administrator/components/com_menus/views/menu/tmpl/edit.php
@@ -18,14 +18,12 @@
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'menu.cancel' || document.formvalidator.isValid(document.id('item-form'))) {
submitform(task);
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_menus'); ?>" method="post" name="adminForm" id="item-form">
View
2 administrator/components/com_menus/views/menus/tmpl/default.php
@@ -21,13 +21,11 @@
$listDirn = $this->state->get('list.direction');
?>
<script type="text/javascript">
-<!--
function submitbutton(task) {
if (task != 'menus.delete' || confirm('<?php echo JText::_('COM_MENUS_MENU_CONFIRM_DELETE',true);?>')) {
submitform(task);
}
}
-// -->
</script>
<form action="<?php echo JRoute::_('index.php?option=com_menus&view=menus');?>" method="post" name="adminForm">
<table class="adminlist">
View
2 administrator/components/com_messages/views/config/tmpl/default.php
@@ -17,14 +17,12 @@
JHtml::_('behavior.keepalive');
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'config.cancel' || document.formvalidator.isValid(document.id('config-form'))) {
submitform(task);
}
}
-// -->
</script>
<form action="<?php echo JRoute::_('index.php?option=com_messages'); ?>" method="post" name="adminForm" id="message-form" class="form-validate">
<fieldset>
View
2 administrator/components/com_messages/views/message/tmpl/edit.php
@@ -17,13 +17,11 @@
JHtml::_('behavior.keepalive');
?>
<script type="text/javascript">
-<!--
function submitbutton(task) {
if (task == 'message.cancel' || document.formvalidator.isValid(document.id('message-form'))) {
submitform(task);
}
}
-// -->
</script>
<form action="<?php echo JRoute::_('index.php?option=com_messages'); ?>" method="post" name="adminForm" id="message-form" class="form-validate">
<div class="width-100">
View
2 administrator/components/com_modules/models/fields/moduleorder.php
@@ -48,7 +48,6 @@ protected function getInput()
$attr .= $this->element['onchange'] ? ' onchange="'.(string) $this->element['onchange'].'"' : '';
$html[] = '<script type="text/javascript">';
- $html[] = '<!-- ';
$ordering = $this->form->getValue('ordering');
$position = $this->form->getValue('position');
@@ -86,7 +85,6 @@ protected function getInput()
}
$html[] = 'writeDynaList(\'name="'.$this->name.'" id="'.$this->id.'"'.$attr.'\', orders, originalPos, originalPos, originalOrder);';
- $html[] = ' //-->';
$html[] = '</script>';
return implode("\n", $html);
View
2 administrator/components/com_modules/views/module/tmpl/edit.php
@@ -18,7 +18,6 @@
$hasContent = empty($this->item->module) || $this->item->module == 'custom' || $this->item->module == 'mod_custom';
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'module.cancel' || document.formvalidator.isValid(document.id('module-form'))) {
@@ -33,7 +32,6 @@ function submitbutton(task)
alert('<?php echo $this->escape(JText::_('COM_MODULES_ERROR_TITLE'));?>');
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_modules'); ?>" method="post" name="adminForm" id="module-form" class="form-validate">
View
2 administrator/components/com_modules/views/module/tmpl/modal.php
@@ -20,7 +20,6 @@
$hasContent = empty($this->item->module) || $this->item->module == 'custom' || $this->item->module == 'mod_custom';
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'module.cancel' || document.formvalidator.isValid(document.id('module-form'))) {
@@ -34,7 +33,6 @@ function submitbutton(task)
alert('<?php echo $this->escape(JText::_('JGLOBAL_VALIDATION_FORM_FAILED'));?>');
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_modules&layout=modal&tmpl=component'); ?>" method="post" name="adminForm" id="module-form" class="form-validate">
View
2 administrator/components/com_newsfeeds/views/newsfeed/tmpl/edit.php
@@ -18,7 +18,6 @@
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'newsfeed.cancel' || document.formvalidator.isValid(document.id('newsfeed-form'))) {
@@ -28,7 +27,6 @@ function submitbutton(task)
alert('<?php echo $this->escape(JText::_('JGLOBAL_VALIDATION_FORM_FAILED'));?>');
}
}
-// -->
</script>
<form action="<?php echo JRoute::_('index.php?option=com_newsfeeds'); ?>" method="post" name="adminForm" id="newsfeed-form" class="form-validate">
View
2 administrator/components/com_plugins/views/plugin/tmpl/edit.php
@@ -15,14 +15,12 @@
JHtml::_('behavior.formvalidation');
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'plugin.cancel' || document.formvalidator.isValid(document.id('style-form'))) {
submitform(task);
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_templates'); ?>" method="post" name="adminForm" id="style-form" class="form-validate">
View
2 administrator/components/com_redirect/views/link/tmpl/edit.php
@@ -18,14 +18,12 @@
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'link.cancel' || document.formvalidator.isValid(document.id('link-form'))) {
submitform(task);
}
}
-// -->
</script>
<form action="<?php echo JRoute::_('index.php?option=com_redirect'); ?>" method="post" name="adminForm" id="link-form" class="form-validate">
View
2 administrator/components/com_templates/views/source/tmpl/edit.php
@@ -16,7 +16,6 @@
JHtml::_('behavior.keepalive');
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'source.cancel' || document.formvalidator.isValid(document.id('source-form'))) {
@@ -27,7 +26,6 @@ function submitbutton(task)
alert('<?php echo $this->escape(JText::_('JGLOBAL_VALIDATION_FORM_FAILED'));?>');
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_templates'); ?>" method="post" name="adminForm" id="source-form" class="form-validate">
View
2 administrator/components/com_templates/views/style/tmpl/edit.php
@@ -16,14 +16,12 @@
$user = JFactory::getUser();
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'style.cancel' || document.formvalidator.isValid(document.id('style-form'))) {
submitform(task);
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_templates'); ?>" method="post" name="adminForm" id="style-form" class="form-validate">
View
2 administrator/components/com_users/views/group/tmpl/edit.php
@@ -19,14 +19,12 @@
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'group.cancel' || document.formvalidator.isValid(document.id('group-form'))) {
submitform(task);
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_users'); ?>" method="post" name="adminForm" id="group-form" class="form-validate">
View
2 administrator/components/com_users/views/level/tmpl/edit.php
@@ -19,7 +19,6 @@
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'level.cancel' || document.formvalidator.isValid(document.id('level-form'))) {
@@ -85,7 +84,6 @@ function submitbutton(task)
});
});
*/
-// -->
</script>
View
2 administrator/components/com_users/views/user/tmpl/edit.php
@@ -21,14 +21,12 @@
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'user.cancel' || document.formvalidator.isValid(document.id('user-form'))) {
submitform(task);
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_users'); ?>" method="post" name="adminForm" id="user-form" class="form-validate">
View
2 administrator/components/com_weblinks/views/weblink/tmpl/edit.php
@@ -15,7 +15,6 @@
JHtml::_('behavior.formvalidation');
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'weblink.cancel' || document.formvalidator.isValid(document.id('weblink-form'))) {
@@ -26,7 +25,6 @@ function submitbutton(task)
alert('<?php echo $this->escape(JText::_('JGLOBAL_VALIDATION_FORM_FAILED'));?>');
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_weblinks'); ?>" method="post" name="adminForm" id="weblink-form" class="form-validate">
View
2 administrator/templates/hathor/html/com_categories/category/edit.php
@@ -22,7 +22,6 @@
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'category.cancel' || document.formvalidator.isValid(document.id('item-form'))) {
@@ -32,7 +31,6 @@ function submitbutton(task)
alert('<?php echo $this->escape(JText::_('JGLOBAL_VALIDATION_FORM_FAILED'));?>');
}
}
-// -->
</script>
<div class="category-edit">
View
2 administrator/templates/hathor/html/com_content/article/edit.php
@@ -20,7 +20,6 @@
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'article.cancel' || document.formvalidator.isValid(document.id('item-form'))) {
@@ -31,7 +30,6 @@ function submitbutton(task)
alert('<?php echo $this->escape(JText::_('JGLOBAL_VALIDATION_FORM_FAILED'));?>');
}
}
-// -->
</script>
<div class="article-edit">
View
2 administrator/templates/hathor/html/com_menus/item/edit.php
@@ -20,7 +20,6 @@
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'item.cancel' || document.formvalidator.isValid(document.id('item-form'))) {
@@ -35,7 +34,6 @@ function submitbutton(task)
});
}
}
-// -->
</script>
<div class="menuitem-edit">
View
2 administrator/templates/hathor/html/com_menus/menu/edit.php
@@ -19,14 +19,12 @@
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'menu.cancel' || document.formvalidator.isValid(document.id('item-form'))) {
submitform(task);
}
}
-// -->
</script>
<div class="menu-edit">
View
2 administrator/templates/hathor/html/com_menus/menus/default.php
@@ -22,13 +22,11 @@
$listDirn = $this->state->get('list.direction');
?>
<script type="text/javascript">
-<!--
function submitbutton(task) {
if (task != 'menus.delete' || confirm('<?php echo JText::_('COM_MENUS_MENU_CONFIRM_DELETE',true);?>')) {
submitform(task);
}
}
-// -->
</script>
<form action="<?php echo JRoute::_('index.php?option=com_menus&view=menus');?>" method="post" name="adminForm" id="adminForm">
<table class="adminlist">
View
2 administrator/templates/hathor/html/com_modules/module/edit.php
@@ -19,7 +19,6 @@
$hasContent = empty($this->item->module) || $this->item->module == 'custom' || $this->item->module == 'mod_custom';
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'module.cancel' || document.formvalidator.isValid(document.id('module-form'))) {
@@ -34,7 +33,6 @@ function submitbutton(task)
alert('<?php echo $this->escape(JText::_('COM_MODULES_ERROR_TITLE'));?>');
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_modules'); ?>" method="post" name="adminForm" id="module-form" class="form-validate">
View
2 administrator/templates/hathor/html/com_modules/module/modal.php
@@ -22,7 +22,6 @@
$hasContent = empty($this->item->module) || $this->item->module == 'custom' || $this->item->module == 'mod_custom';
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'module.cancel' || document.formvalidator.isValid(document.id('module-form'))) {
@@ -36,7 +35,6 @@ function submitbutton(task)
alert('<?php echo $this->escape(JText::_('JGLOBAL_VALIDATION_FORM_FAILED'));?>');
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_modules&layout=modal&tmpl=component'); ?>" method="post" name="adminForm" id="module-form" class="form-validate">
View
2 administrator/templates/hathor/html/com_newsfeeds/newsfeed/edit.php
@@ -19,7 +19,6 @@
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'newsfeed.cancel' || document.formvalidator.isValid(document.id('newsfeed-form'))) {
@@ -29,7 +28,6 @@ function submitbutton(task)
alert('<?php echo $this->escape(JText::_('JGLOBAL_VALIDATION_FORM_FAILED'));?>');
}
}
-// -->
</script>
<form action="<?php echo JRoute::_('index.php?option=com_newsfeeds'); ?>" method="post" name="adminForm" id="newsfeed-form" class="form-validate">
View
2 administrator/templates/hathor/html/com_plugins/plugin/edit.php
@@ -15,14 +15,12 @@
JHtml::_('behavior.formvalidation');
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'plugin.cancel' || document.formvalidator.isValid(document.id('style-form'))) {
submitform(task);
}
}
-// -->
</script>
<form action="<?php JRoute::_('index.php?option=com_plugins'); ?>" method="post" name="adminForm" id="style-form" class="form-validate">
View
2 administrator/templates/hathor/html/com_weblinks/weblink/edit.php
@@ -16,7 +16,6 @@
JHtml::_('behavior.formvalidation');
?>
<script type="text/javascript">
-<!--
function submitbutton(task)
{
if (task == 'weblink.cancel' || document.formvalidator.isValid(document.id('weblink-form'))) {
@@ -27,7 +26,6 @@ function submitbutton(task)
alert('<?php echo $this->escape(JText::_('JGLOBAL_VALIDATION_FORM_FAILED'));?>');
}
}
-// -->
</script>
<div class="weblink-edit">
View
5 components/com_contact/views/contact/tmpl/default_form.php
@@ -9,7 +9,7 @@
*/
defined('_JEXEC') or die;
JHtml::_('behavior.keepalive');
- $script = '<!--
+ $script = '
function validateForm(frm) {
var valid = document.formvalidator.isValid(frm);
if (valid == false) {
@@ -23,8 +23,7 @@ function validateForm(frm) {
} else {
frm.submit();
}
- }
- // -->';
+ }';
$document = JFactory::getDocument();
$document->addScriptDeclaration($script); ?>
View
2 components/com_mailto/views/mailto/tmpl/default.php
@@ -12,7 +12,6 @@
JHtml::_('behavior.keepalive');
?>
<script type="text/javascript">
-<!--
function submitbutton(pressbutton) {
var form = document.mailtoForm;
@@ -23,7 +22,6 @@ function submitbutton(pressbutton) {
}
form.submit();
}
--->
</script>
<?php
$data = $this->get('data');
View
2 installation/CHANGELOG
@@ -32,6 +32,8 @@ $ -> Language fix or change
# Fixed issue [#21394] Problem with submenu translation in 3rd party extensions (Rune Sjøen).
# Fixed issue [#21452] Use rel="help" for the help button in the toolbar (Rouven Weßling).
# Fixed issue [#21438] Adding categories (Rune Sjøen).
+ # Fixed issue [#21247] HTML comments shouldn't be used to guard JavaScript (Rouven Weßling).
+
21-Jul-2010 Jean-Marie Simonet
$ Changing all occurences of :: to : : in strings' values to avoid breaking tooltips
View
3 installation/gpl.html
@@ -4,8 +4,6 @@
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Untitled Document</title>
<style type="text/css">
-<!--
-
body {
font-family: arial, helvetica, sans serif;
font-size: 11px;
@@ -53,7 +51,6 @@
pre {
font-size: 11px;
}
--->
</style>
</head>
<body>
View
3 installation/migration.html
@@ -4,8 +4,6 @@
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Loading</title>
<style type="text/css">
-<!--
-
body {
font-family: arial, helvetica, sans serif;
font-size: 11px;
@@ -53,7 +51,6 @@
pre {
font-size: 11px;
}
--->
</style>
</head>
<body>&nbsp;</body>
View
2 installation/views/complete/tmpl/default.php
@@ -19,11 +19,9 @@
?>
<script type="text/javascript">
-<!--
function validateForm(frm, task) {
Joomla.submitform(task);
}
-// -->
</script>
<div id="stepbar">
View
2 installation/views/database/tmpl/default.php
@@ -19,11 +19,9 @@
?>
<script type="text/javascript">
-<!--
function validateForm(frm, task) {
Joomla.submitform(task);
}
-// -->
</script>
<div id="stepbar">
View
2 installation/views/filesystem/tmpl/default.php
@@ -19,11 +19,9 @@
?>
<script type="text/javascript">
-<!--
function validateForm(frm, task) {
Joomla.submitform(task);
}
-// -->
</script>
<div id="stepbar">
View
2 installation/views/language/tmpl/default.php
@@ -19,11 +19,9 @@
?>
<script type="text/javascript">
-<!--
function validateForm(frm, task) {
Joomla.submitform(task);
}
-// -->
</script>
<div id="stepbar">
View
2 installation/views/license/tmpl/default.php
@@ -19,11 +19,9 @@
?>
<script type="text/javascript">
-<!--
function validateForm(frm, task) {
Joomla.submitform(task);
}
-// -->
</script>
<div id="stepbar">
View
2 installation/views/preinstall/tmpl/default.php
@@ -19,11 +19,9 @@
?>
<script type="text/javascript">
-<!--
function validateForm(frm, task) {
Joomla.submitform(task);
}
-// -->
</script>
<div id="stepbar">
View
2 installation/views/site/tmpl/default.php
@@ -19,7 +19,6 @@
?>
<script type="text/javascript">
-<!--
function validateForm(frm, task) {
Joomla.submitform(task);
}
@@ -31,7 +30,6 @@ function validateForm(frm, task) {
el.setAttribute('value','<?php echo JText::_('INSTL_SITE_SAMPLE_LOADED', true); ?>');
});
<?php endif; ?>
-// -->
</script>
<div id="stepbar">
View
12 libraries/joomla/document/html/renderer/head.php
@@ -101,20 +101,14 @@ public function fetchHead(&$document)
$buffer .= $tab.'<style type="'.$type.'">'.$lnEnd;
// This is for full XHTML support.
- if ($document->_mime == 'text/html') {
- $buffer .= $tab.$tab.'<!--'.$lnEnd;
- }
- else {
+ if ($document->_mime != 'text/html') {
$buffer .= $tab.$tab.'<![CDATA['.$lnEnd;
}
$buffer .= $content . $lnEnd;
// See above note
- if ($document->_mime == 'text/html') {
- $buffer .= $tab.$tab.'-->'.$lnEnd;
- }
- else {
+ if ($document->_mime != 'text/html') {
$buffer .= $tab.$tab.']]>'.$lnEnd;
}
$buffer .= $tab.'</style>'.$lnEnd;
@@ -139,7 +133,7 @@ public function fetchHead(&$document)
// See above note
if ($document->_mime != 'text/html') {
- $buffer .= $tab.$tab.'// ]]>'.$lnEnd;
+ $buffer .= $tab.$tab.']]>'.$lnEnd;
}
$buffer .= $tab.'</script>'.$lnEnd;
}
View
5 templates/rhuk_milkyway/_html/com_contact/contact/default_form.php
@@ -2,7 +2,7 @@
/** $Id$ */
defined( '_JEXEC' ) or die( 'Restricted access' );
- $script = '<!--
+ $script = '
function validateForm( frm ) {
var valid = document.formvalidator.isValid(frm);
if (valid == false) {
@@ -16,8 +16,7 @@ function validateForm( frm ) {
} else {
frm.submit();
}
- }
- // -->';
+ }';
$document = JFactory::getDocument();
$document->addScriptDeclaration($script);
View
2 templates/rhuk_milkyway/_html/com_content/article/form.php
@@ -12,7 +12,6 @@
?>
<script type="text/javascript">
-<!--
function setgood() {
// TODO: Put setGood back
return true;
@@ -56,7 +55,6 @@ function submitbutton(pressbutton) {
<?php echo $this->editor->save( 'text' ); ?>
submitform(pressbutton);
}
-//-->
</script>
<?php if ($this->params->get('show_page_heading', 1)) : ?>
<div class="componentheading<?php echo $this->escape($this->params->get('pageclass_sfx')); ?>"><?php echo $this->escape($this->params->get('page_title')); ?></div>
View
2 templates/rhuk_milkyway/_html/com_mailto/mailto/default.php
@@ -1,7 +1,6 @@
<?php // no direct access
defined('_JEXEC') or die; ?>
<script type="text/javascript">
-<!--
function submitbutton(pressbutton) {
var form = document.mailtoForm;
@@ -12,7 +11,6 @@ function submitbutton(pressbutton) {
}
form.submit();
}
--->
</script>
<?php
$data = $this->get('data');
View
2 templates/rhuk_milkyway/_html/com_mailto/sent/default.php
@@ -1,7 +1,6 @@
<?php // no direct access
defined('_JEXEC') or die; ?>
<script type="text/javascript">
-<!--
function submitbutton(pressbutton) {
var form = document.mailtoForm;
@@ -12,7 +11,6 @@ function submitbutton(pressbutton) {
}
form.submit();
}
--->
</script>
<?php
$data = $this->get('data');
View
2 templates/rhuk_milkyway/_html/com_newsfeeds/categories/default.php
@@ -1,7 +1,6 @@
<?php // no direct access
defined('_JEXEC') or die; ?>
<script type="text/javascript">
-<!--
function submitbutton(pressbutton) {
var form = document.mailtoForm;
@@ -12,7 +11,6 @@ function submitbutton(pressbutton) {
}
form.submit();
}
--->
</script>
<?php
$data = $this->get('data');
View
2 templates/rhuk_milkyway/_html/com_user/register/default.php
@@ -1,11 +1,9 @@
<?php // no direct access
defined('_JEXEC') or die; ?>
<script type="text/javascript">
-<!--
Window.onDomReady(function(){
document.formvalidator.setHandler('passverify', function (value) { return (document.id('password').value == value); } );
});
-// -->
</script>
<?php
View
2 templates/rhuk_milkyway/_html/com_user/user/form.php
@@ -2,11 +2,9 @@
defined('_JEXEC') or die; ?>
<script type="text/javascript">
-<!--
Window.onDomReady(function(){
document.formvalidator.setHandler('passverify', function (value) { return (document.id('password').value == value); } );
});
-// -->
</script>
<form action="<?php echo JRoute::_( 'index.php' ); ?>" method="post" name="userform" autocomplete="off" class="form-validate">

0 comments on commit 7819849

Please sign in to comment.