Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search by page option missing in module manager J3.7 #15621

Closed
AndLincoln opened this issue Apr 27, 2017 · 26 comments
Closed

Search by page option missing in module manager J3.7 #15621

AndLincoln opened this issue Apr 27, 2017 · 26 comments

Comments

@AndLincoln
Copy link

AndLincoln commented Apr 27, 2017

The option to search by page in module manager search tools has disappeared in Joomla 3.7

@brianteeman
Copy link
Contributor

I can confirm that this is a bug

@brianteeman
Copy link
Contributor

The bug is that this line which exists so that the page type is only displayed as a filter for site modules is not being processed

https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_modules/models/forms/filter_modules.xml#L55

@ghost
Copy link

ghost commented May 5, 2017

I have the same issue. Is there a solution for this?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15621.

@brotherdoomsday
Copy link

I to have the same issue with J3.7, is there a solution for this? The question should be how soon will there be a solution for this ?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15621.

@vebnara
Copy link

vebnara commented May 9, 2017

A temp work around or anyone who needs it is to edit /administrator/components/com_modules/models/forms/filter_modules.xml and remove line 55 which is 'showon="client_id:0"' the page filter will reappear for you.

@ufuk-avcu
Copy link

I can confirm this problem also in Joomla 3.7.0

@communic8
Copy link

The problem is not solved in J3.7.1

@AlexRed
Copy link
Contributor

AlexRed commented May 19, 2017

Sorry, but there is a rule here that does not allow to confirm yet an open issue :(

@infograf768
Copy link
Member

I am looking now for a solution.

@ghost
Copy link

ghost commented May 19, 2017

@AlexRed i thinks its helpfull to confirm a new issue. It doesn't help if many People confirm after each update that Issue exists.

@AlexRed
Copy link
Contributor

AlexRed commented May 19, 2017

Hello @franz-wohlkoenig, also I thinks its helpfull to confirm the issue in a new Joomla version, but when I do it I was accused of be a troll 8244#issuecomment-298604672 :(
I believe that if this rule exists, it must be respected for everyone.

@infograf768
Copy link
Member

@AlexRed @franz-wohlkoenig @communic8
Please test #16118

Closing as we have a patch

@mbabker
Copy link
Contributor

mbabker commented May 19, 2017

also I thinks its helpfull to confirm the issue in a new Joomla version, but when I do it I was accused of be a troll

The issue in your case is you went to several issues which had already been confirmed as issues and had clearly had no action taken on those issues just to state "yep, still an issue". We don't need that kind of reconfirmation on confirmed issues with every release. If/When someone decides to work on the issue, they'd have to confirm they can duplicate it to fix it anyway so at that point if they can't confirm it either they ask for additional info or can close the item.

Yes, it is helpful when a few folks can confirm something, but we don't need a new post of "still an issue" every few days.

@AlexRed
Copy link
Contributor

AlexRed commented May 19, 2017

sure, not every few days. But can I write after tens of days and for different Joomla version?

@brianteeman
Copy link
Contributor

As stated by @mbabker no you cannot. It serves no value at all. If it is such a major issue for you then submit a pr or find someone who can.

@AlexRed
Copy link
Contributor

AlexRed commented May 19, 2017

ok, but this rule is for all or only for me ?

@mbabker
Copy link
Contributor

mbabker commented May 19, 2017

It's a general rule of thumb. Once an issue is confirmed, we don't need people to post on it reminding us that there is an open confirmed issue. Obviously we can't stop people from doing it, but as a courtesy, we ask that you don't. For some the issue will be more important than others, but it will either eventually get fixed or remain in an open and confirmed state.

@AlexRed
Copy link
Contributor

AlexRed commented May 19, 2017

ok, here I write it: #15621 (comment)
but franz-wohlkoenig say its helpfull to confirm, I know for you and Brian is not helpfull.

@mbabker
Copy link
Contributor

mbabker commented May 19, 2017

When an issue is first opened, it is helpful to test and confirm the issue actually exists. But if we needed to reconfirm every open issue with every release we honestly wouldn't get much else done because we'd spend most of our time retesting 400+ open issues every few weeks.

Maybe if an issue was opened around 3.6.1 or 3.6.2 it'd be good to reconfirm it. But for something opened during the 3.7 beta/RC or after 3.7.0, not so much.

@AlexRed
Copy link
Contributor

AlexRed commented May 19, 2017

ok, like I write here: "Sorry, but there is a rule here that does not allow to confirm yet an open issue :("

ok to reconfirm it for old issue.

@mbabker
Copy link
Contributor

mbabker commented May 19, 2017

I can't speak for the workflow of others, but in my case, I manage and monitor GitHub almost exclusively through email for projects where I have some kind of maintainership role, which means I'm getting email notifications for everything (commit comments, new commits on PRs, new issues/PRs, items being closed). It adds to the amount of time I have to spend in my email clearing my queue when there is a stream of "issue still exists" messages. For items that are still fairly new, I don't feel like those messages are adding any value. When it's an older issue (I'd say 3-4 months old minimum), it can be helpful.

@AlexRed
Copy link
Contributor

AlexRed commented May 19, 2017

ok, I hope all we can use this rule.

@rdeutz
Copy link
Contributor

rdeutz commented May 19, 2017

The other way around would be more helpful, I am pretty sure a lot of the 500 issues we have are obsolet so we could close them. If someone would go to the old ones and commenting when an issue is no longer valid then we could concentrate on the valid ones.

@AlexRed
Copy link
Contributor

AlexRed commented May 19, 2017

For example the issue where brian accuses me of being a troll is 564 day old. It's right to be accused or just right reconfirm it for old issue.

Now I confirm one old 146 day, is it ok? #13365 (comment)

@ghost
Copy link

ghost commented May 19, 2017 via email

@vebnara
Copy link

vebnara commented May 19, 2017

THIS IS CRAZY OVER 20 NOTIFICATIONS IN AN HOUR NONE OF WHICH RELATE TO THE ISSUE.

You have gone totally off topic, this isn't a bitching forum about how git hub or the joomla Dec team handles bug reports. It's about a specific issue to which I posted a work around to 10 days ago.

PLEASE STOP COMMENTING UNLESS IT'S TO ADD SOMETHING MEANINGFUL TO THE ISSUE.

ps I know I've just added to the mails and for that I'm sorry but hopefully everyone will be respectful and get back on topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests