Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jalali calendar broken #16590

Closed
infograf768 opened this issue Jun 9, 2017 · 14 comments
Closed

Jalali calendar broken #16590

infograf768 opened this issue Jun 9, 2017 · 14 comments

Comments

@infograf768
Copy link
Member

infograf768 commented Jun 9, 2017

When using the Persian calendar and choosing another day than the present day, then hitting return, it is always the present day which is displayed/saved.

@dgt41

Release blocker

Test made here on publishing date:

jalali

@dgrammatiko
Copy link
Contributor

@infograf768 according to the code: https://github.com/joomla/joomla-cms/blob/staging/media/system/js/fields/calendar.js#L540-L544
shift + enter is the enter equal (accept value and enter is the same as escape. I don't remember why we did it like this

@infograf768
Copy link
Member Author

@dgt41
Enter alone works for en-GB

@infograf768
Copy link
Member Author

Tried shift enter and tab => same result

@infograf768
Copy link
Member Author

Also, if the Publishing field is empty for example, when i choose today, it does not save here at all. Field is saved empty

@Bakual
Copy link
Contributor

Bakual commented Jun 9, 2017

"Enter" acting as "Escape" certainly is wrong and unexpected behavior. "Shift-Enter" is basically a useless combinations since there is no hint that we can use that 😄

@dgrammatiko
Copy link
Contributor

@Bakual I don't remember the exact reason but had to do with the ability to keep the manual input of text in the field, you might remember that discussion...

@infograf768
Copy link
Member Author

The other issue when field is empty (Publishing field)

jalali2

@dgrammatiko
Copy link
Contributor

The other issue when field is empty (Publishing field)

Try to close it with close button, does it work then? (then the problem is the blur code, modified recently)

@infograf768
Copy link
Member Author

Nope.

@farhadst
Copy link

Hi
This problem arose in joomla 3.7
After the digit were written in Persian
I also can not manually enter a date
There was no such problem in joomla 3.6, which was the English digit.
Now for choose another day before today, i should first choosing hour and then choose the day.
but after change any digit, date reset to today

@farhadst
Copy link

farhadst commented Jun 12, 2017

I have change digit in media/system/js/fields/calendar-locales/fa-ir.js from persian to latin
cal
but problem not fix, then replace media/system/js/fields/calendar.min.js by same file in joomla 3.7 package, and some problem fix
cal2

also i can not manually enter a date

@infograf768
Copy link
Member Author

Closing as we have a patch #16794

@denysdesign
Copy link
Contributor

Calendar always saves seconds like ":00"

  1. If select TODAY in datepicker set date and time as 2017-06-29 04:17:47 but after save replace date and time as 2017-06-29 04:17:00
  2. Always save article with seconds like ":00"

#16908

@ghost
Copy link

ghost commented Jun 29, 2017

@joomla-ua thanks for reporting. As you have open a new Issue its not necessary to report same issue on another, closed issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants