Port back MVC from 4 and add type to MVC class name in MVC factory #17681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laoneo
changed the title
laoneo
changed the title
laoneo
added a commit
to Digital-Peak/joomla-cms
that referenced
this pull request
Sep 11, 2017
…oomla#17681) * Add type to MVC class name in MVC factory * Port back the MVCFactory from 4.0 * CS (cherry picked from commit a77b00b)
wilsonge
pushed a commit
that referenced
this pull request
Sep 20, 2017
* Port back MVC from 4 and add type to MVC class name in MVC factory (#17681) * Add type to MVC class name in MVC factory * Port back the MVCFactory from 4.0 * CS (cherry picked from commit a77b00b) * Rename the classes * Convert the models used in code * Fix some not regular stuff * Remove obsolete code * Update installer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was part of pr #17615 and got somehow deleted. The MVC classes in the component needs to end with the type to be inline with the rest of the namespaced classes. See #17614 for more details. For example the Articles model which has now the name
Joomla\Component\Administrator\Model\Articleswill become thenJoomla\Component\Administrator\Model\ArticlesModel.Additionally it ports back the MVCFactory code from the 4 branch.