Rename MVC classes and add type as prefix for the MVC classes #17615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs to be synced up since I merged staging up to the 3.9 branch and also moved the MVC factory classes to the right directory. |
|
Merged. |
|
You don't actually have the type in this PR. So this is just a renaming of the classes and stuff. But I'm good with that |
This was referenced Aug 23, 2017
wilsonge
pushed a commit
that referenced
this pull request
Sep 8, 2017
* Move mvc classes to MVC namespace and give them better names (#17614) * Move mvc classes to MVC namespace and give them better names * Fixing tests (cherry picked from commit f9aa342) * Rename MVC classes and add type as prefix for the MVC classes (#17615) * Rename MVC classes and add type as prefix for the MVC classes * Moved to correct folder * fgh * Cleanup * Cleanup * CS (cherry picked from commit 4c6ad38) * Sync * Move files to right place * Rename to uppercase MVC * Add MVC to namespace in extensions * Add MVC to namespace in extensions for BaseModel * Add MVC to namespace in extensions for HtmlView * Add MVC to namespace in extensions for FormModel * Add MVC to namespace in extensions for FormController * Add MVC to namespace in extensions for AdminModel * Add MVC to namespace in extensions for BaseController * Add MVC to namespace in extensions for AdminController * Add MVC to namespace in extensions for ItemModel * Add MVC to namespace in extensions for CategoryView * Fix users * Adapt post save hook function * CS * Revert * Fix tests * Missed merge * Move to BaseModel * Ns it * Adapt docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #16941.
Summary of Changes
Renames the namesapce and the existing MVC factory classe names to upper case MVC. Additionally it fixes an issue where the factory is not passed down the hierarchy from the models and controllers which do extend from the base model/controller.
The important change is that the MVC classes in the component needs to end with the type to be inline with the rest of the namespaced classes. See #17614 for more details. For example the Articles model which has now the name
Joomla\Component\Administrator\Model\Articleswill become thenJoomla\Component\Administrator\Model\ArticlesModel.If this one gets merged, then I will adapt the extensions in the 4.0-dev branch accordingly.
Testing Instructions
Expected result
All is working as expected.
Actual result
All is working as expected.
Documentation Changes Required
If there is already documentation written for the MVC factories, then it needs to be updated.