Move mvc classes to MVC namespace and give them better names #17614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
CI issues... |
|
Tests fixed. |
This was referenced Aug 23, 2017
wilsonge
pushed a commit
that referenced
this pull request
Sep 8, 2017
* Move mvc classes to MVC namespace and give them better names (#17614) * Move mvc classes to MVC namespace and give them better names * Fixing tests (cherry picked from commit f9aa342) * Rename MVC classes and add type as prefix for the MVC classes (#17615) * Rename MVC classes and add type as prefix for the MVC classes * Moved to correct folder * fgh * Cleanup * Cleanup * CS (cherry picked from commit 4c6ad38) * Sync * Move files to right place * Rename to uppercase MVC * Add MVC to namespace in extensions * Add MVC to namespace in extensions for BaseModel * Add MVC to namespace in extensions for HtmlView * Add MVC to namespace in extensions for FormModel * Add MVC to namespace in extensions for FormController * Add MVC to namespace in extensions for AdminModel * Add MVC to namespace in extensions for BaseController * Add MVC to namespace in extensions for AdminController * Add MVC to namespace in extensions for ItemModel * Add MVC to namespace in extensions for CategoryView * Fix users * Adapt post save hook function * CS * Revert * Fix tests * Missed merge * Move to BaseModel * Ns it * Adapt docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #16941.
Summary of Changes
This pr moves the Model*, Contoller* and View* classes to the
Joomla\CMS\MVC\namespace. Additionally it appends Model, View Contoller to the classnames for better understanding of the class, like in the rest of the libraries classes.Joomla 4 impact
If merged, then I will adapt the extensions in the 4.0-dev branch to the new class names. Ping @wilsonge.
Testing Instructions
Open the back end.
Expected result
All is working as expected.
Actual result
All is working as expected.
Documentation Changes Required
If there is already documentation written for the namespaced libraries, then it needs to be updated.