Modules - number not text

[brianteeman]

Numerous options in the modules are for numbers but the xml field type is text. This pr changes them to the correct value of number.

This ensures that a user cannot enter a letter and only numbers. There are no b/c issues as only a numerical character could ever have worked and there is no change in the way the data is stored.

I spotted this when debugging a user's site where they put "five" in the count field instead of "5" and wondered why it didnt work. After this PR that isnt possible

[Quy]

I have tested this item ✅ successfully on af71c95

Code review

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18194.}

[chmst]

I have tested this item 🔴 unsuccessfully on af71c95

Tested successfully on some modules, but unsuccessfully on modules/mod_articles_category/mod_articles_category

Additionally there could be used a filter="integer".

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18194.}

[brianteeman]

@chmst can you give some more information please as I cannot tell from your test what doesnt work

[chmst]

You have for the Field count type="numbertext". It doenst work, of course. only a typo :) , but should not be merged.

[brianteeman]

That was already fixed af71c95

[chmst]

This was not visible when I startet testing. So I can repeat the tests.

[chmst]

I have tested this item ✅ successfully on af71c95

Repeated some tests and inspection.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18194.}

[ghost]

RTC after two successful tests.

[infograf768]

@mbabker
3.8.1 ?

[brianteeman]

There is no rush to get this merged. Today I will be reviewing components and plugins for the same

[infograf768]

See my comment here:
#18199 (comment)

[brianteeman]

See my reply #18199 (comment)

[brianteeman]

Thanks