Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules - number not text #18194

Merged
merged 2 commits into from
Oct 5, 2017
Merged

Modules - number not text #18194

merged 2 commits into from
Oct 5, 2017

Commits on Oct 2, 2017

  1. Modules - number not text 

    Numerous options in the modules are for numbers but the xml field type is text. This pr changes them to the correct value of number.

This ensures that a user cannot enter a letter and only numbers. There are no b/c issues as only a numerical character could ever have worked and there is no change in the way the data is stored.

I spotted this when debugging a user's site where they put "five" in the count field instead of "5" and wondered why it didnt work. After this PR that isnt possible
    @brianteeman
    brianteeman committed Oct 2, 2017
    Configuration menu
    Copy the full SHA
    83cdccc View commit details
    Browse the repository at this point in the history

  2. fix

    @brianteeman
    brianteeman committed Oct 2, 2017
    Configuration menu
    Copy the full SHA
    af71c95 View commit details
    Browse the repository at this point in the history