-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modules - number not text #18194
Modules - number not text #18194
Conversation
Numerous options in the modules are for numbers but the xml field type is text. This pr changes them to the correct value of number. This ensures that a user cannot enter a letter and only numbers. There are no b/c issues as only a numerical character could ever have worked and there is no change in the way the data is stored. I spotted this when debugging a user's site where they put "five" in the count field instead of "5" and wondered why it didnt work. After this PR that isnt possible
I have tested this item ✅ successfully on af71c95 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18194. |
I have tested this item 🔴 unsuccessfully on af71c95 Additionally there could be used a filter="integer". This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18194. |
@chmst can you give some more information please as I cannot tell from your test what doesnt work |
You have for the Field count type="numbertext". It doenst work, of course. only a typo :) , but should not be merged. |
That was already fixed af71c95 |
This was not visible when I startet testing. So I can repeat the tests. |
I have tested this item ✅ successfully on af71c95 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18194. |
RTC after two successful tests. |
@mbabker |
There is no rush to get this merged. Today I will be reviewing components and plugins for the same |
See my comment here: |
See my reply #18199 (comment) |
Thanks |
Numerous options in the modules are for numbers but the xml field type is text. This pr changes them to the correct value of number.
This ensures that a user cannot enter a letter and only numbers. There are no b/c issues as only a numerical character could ever have worked and there is no change in the way the data is stored.
I spotted this when debugging a user's site where they put "five" in the count field instead of "5" and wondered why it didnt work. After this PR that isnt possible