[ChangeItem] - the check query should return array instead of object - PHP 7.2

[alikon]

Pull Request for Issue #18437.

Summary of Changes

from object loadObject() to array loadRowList(0)

Testing Instructions

see #18437 with php 7.2
test that Database check works as before

[ghazal]

This change helped me solve a restoration pb with Akeeba with PHP 7.2.0.
Same error as in issue #18437 after restoration from a server with PHP 7.1.7 to the one with
PHP 7.2.0.
I had to delete the file 2.5.0-2011-12-24.sql though.

Well, it seems that this has not been implemented yet in the most recent distribution. ???

[ghost]

@ghazal this Pull Request has not 2 successfully Tests.

[ghazal]

I have tested this item ✅ successfully on 502c62c

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18443.}

[ghazal]

Quick check with J!3.8.3.RC - a fresh install - on a PHP 7.2.0 environment.
Same pb.
Same solution.
No surprise.

[Quy]

Tested with PR #19134.

Do you know why this was detected?
Table 'ch56a_menu' does not have index 'idx_client_id_parent_id_alias_language'. (From file 2.5.0-2011-12-24.sql.)
which resulted:
Duplicate key name 'idx_client_id_parent_id_alias_language'

without this PR:

    Database schema version (3.8.2-2017-10-14) does not match CMS version (3.9.0-2017-12-22).
    Table 'zcag2_content' does not have column 'note'. (From file 3.9.0-2017-12-22.sql.)

with this PR:

    Database schema version (3.8.2-2017-10-14) does not match CMS version (3.9.0-2017-12-22).
    Table 'ch56a_menu' does not have index 'idx_client_id_parent_id_alias_language'. (From file 2.5.0-2011-12-24.sql.)
    Table 'ch56a_content' does not have column 'note'. (From file 3.9.0-2017-12-22.sql.)

[alikon]

i'll look at it....

[alikon]

@Quy can you re-check ?
@ghazal please re-test

[Quy]

I have tested this item ✅ successfully on 86c4cc8

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18443.}

[ghazal]

I have tested this item ✅ successfully on 86c4cc8

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18443.}

[ghost]

Ready to Commit after two successful tests.

[alikon]

can someone re-add the 3.8.4 milestone ?